diff options
author | Nelson Chu <nelsonc@gamma05.internal.sifive.com> | 2019-11-20 18:49:34 -0800 |
---|---|---|
committer | Nelson Chu <nelson.chu@sifive.com> | 2020-02-16 18:04:42 -0800 |
commit | b9e85d5046c175cd738d29786baed9ab4e6820eb (patch) | |
tree | 7cf27985dcf89e376c31b5e4a83680671772e11b /test | |
parent | 93f8ca3c14d568d6b7528340d3583092accbcf1a (diff) | |
download | riscv-gnu-toolchain-b9e85d5046c175cd738d29786baed9ab4e6820eb.zip riscv-gnu-toolchain-b9e85d5046c175cd738d29786baed9ab4e6820eb.tar.gz riscv-gnu-toolchain-b9e85d5046c175cd738d29786baed9ab4e6820eb.tar.bz2 |
Add binuitls testsuite pr-24406-1 to the white list for newlib.
This testcase is used to check whether the linker is work normally when both
the --wrap=SYMBOL and -flto are set. It seems that the current fix only can
work when the wrapped symbol `SYMBOL` is defined in the other files and will be
linked. See the pr-24406-1 test, the `read` symbol is defined in the glibc’s
libc.so.6, and we will also link the libc.so.6 by the linux toolchain, so it
works. But the `read` symbol isn’t defined in the newlib, or other linked
objects or archives. Therefore, the pr-24406-1 testsuite is always failed
for riscv elf toolchain, but seems to work for riscv linux toolchain.
On the other hand, if the wrapped symbol is `read_p`, it isn't defined in the
other linked files, so we also get the error link for the linux toolchain.
The fix in upstream seems not complete. I suppose that we shoud just skip the
pr-24406-1 testcase until upstream fix or remove it.
Diffstat (limited to 'test')
-rw-r--r-- | test/whitelist/binutils/newlib.log | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/test/whitelist/binutils/newlib.log b/test/whitelist/binutils/newlib.log index 79b9698..57ffc2d 100644 --- a/test/whitelist/binutils/newlib.log +++ b/test/whitelist/binutils/newlib.log @@ -7,3 +7,9 @@ FAIL: Build libpr23958.so # XXX: Unknown reason. # FAIL: Build pr22983 +# +# This testcase is used to check whether the linker is work normally when both +# the --wrap=SYMBOL and -flto are set. This fail isn’t caused by the riscv +# toolchain port, so we shoud skip it until the upstream fix the problem. +# +FAIL: Run pr24406-1 |