| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
[debug] Reserve triggers propperly in HwbpManual
|
|
https://github.com/riscv-collab/riscv-openocd/pull/1111 introduces a
change in OpenOCD behavior: a manual trigger should be manually removed
to step/resume from it.
This was not concidered in previous stop-gap solutions
(76ff703d9161945354e334afa45c5dfe7680da60 and
8cc4918e904ca009cd85350fadf6f44e91eca13c)
This commit:
1. Determines if `reserve trigger` is supported by the target.
This can be removed once
https://github.com/riscv-collab/riscv-openocd/pull/1111 is merged.
2. Marks `HwbpManual` test as not applicable in case `reserve trigger`
is not supported.
3. Accounts for the change in OpenOCD's behavior when stepping from a
manual BP.
4. Cleans up some minor mistakes in `HwbpManual`
|
|
[debug] Fix trigger reservation in HwbpManual
|
|
Syntax of the command was changed: (on/off) became compulsory.
|
|
[debug] Reserve the trigger in `HwbpManual`
|
|
There is already a mechanism for the test target to supply a known-bad
address, so use that address if it is provided.
|
|
issue#577
In the newest riscv spec(2021 or later), two csr register
"sptbr"(0x180) "s/mbadaddr"(0x243) were removed,
and upgraded to "satp" "s/mtval". Together with more functions.
This commit rename them to pass compile.
|
|
After https://github.com/riscv-collab/riscv-openocd/pull/1111 is merged,
the registers a user wishes to have direct control of should be
reserved.
This is the case in `HwbpManual`.
The test still works with older OpenOCD versions, since no exception
is generated when a command (`riscv reserve_trigger` in this case)
is not found.
|
|
The file was added by 00ab5f0dd4cf56b5a0551bc5adedf60c765d0c66 in #567.
Seems like a mistake.
```
> readelf -h debug/test
ELF Header:
Magic: 7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00
Class: ELF64
Data: 2's complement, little endian
Version: 1 (current)
OS/ABI: UNIX - System V
ABI Version: 0
Type: EXEC (Executable file)
Machine: RISC-V
Version: 0x1
Entry point address: 0x1212340000
Start of program headers: 64 (bytes into file)
Start of section headers: 16552 (bytes into file)
Flags: 0x0
Size of this header: 64 (bytes)
Size of program headers: 56 (bytes)
Number of program headers: 2
Size of section headers: 64 (bytes)
Number of section headers: 18
Section header string table index: 17
```
|
|
merge .bss.* to .bss then entry.S can clear it.
|
|
|
|
Signed-off-by: Daniel Maslowski <info@orangecms.org>
|
|
|
|
Debug: suppress `PRNG seed ...` log messages when `gdbserver.py --list-tests <target>` used
|
|
|
|
|
|
|
|
testlib.py:run_all_tests()
|
|
https://github.com/riscv-software-src/riscv-tests/pull/531#issuecomment-2151081139
|
|
debug: fix HwbpManual test
|
|
Continuation of fee361fd89edd4ac031a570affde16f4f84414e9
|
|
By using Zca-friendly registers, we can reuse the existing tests to get
quick-and-dirty coverage of Zca, when the assembler is told to use Zca.
(This doesn't break non-Zca targets.)
|
|
HwbpManual test was broken:
* Value read back from `tselect` was compared with `tdata1` value.
https://github.com/riscv-software-src/riscv-tests/blob/408e461da11e0b298c4b69e587729532787212f5/debug/gdbserver.py#L701-L703
This resulted in the test being reported as not supported, after all the
triggers were checked.
* `tdata1.type` field was not set to `mcontrol`.
* `tselect` value used to be changed by `handle_reset` and not restored.
https://github.com/riscv-software-src/riscv-tests/blob/408e461da11e0b298c4b69e587729532787212f5/debug/programs/entry.S#L79-L84
* Manual breakpoint used to be left behind.
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
|
|
debug: workaround for sporadic failures of some tests due to unexpected data present in pexpect match
|
|
debug: fix sporadic failures of memory sampling tests
|
|
Memory sampling tests fail sporadically for spike targets. A typical
failure looks as follows (ROI from test log):
```
---------------------------------[ Message ]----------------------------------
139670831 not less than 124104544
--------------------------------[ Traceback ]---------------------------------
... SECTION IS SKIPPED FOR READABILITY ...
raise TestFailed(f"{a!r} not less than {b!r}", comment)
testlib.TestFailed
```
Few observations:
- 139670831 is 0x0853352f in hex, while 124104544 is 0x0765af60
- Now, the assert which is failing corresponds to the following
expression:
```
assertLess(value, previous_value + tolerance)
```
- tolerance is `0x500000`. (124104544 - 0x500000) is 0x0715af60
If we look at the sampling output for such failing test, we'll see:
```
...
0x1212340c5c: 0x0715af60
timestamp after: 878087500
timestamp before: 878088133
0x1212340c5c: 0x0853352f
...
```
The log above demonstrates the reason for the failure. Since memory
sampling occures every poll (which by default happens approximately
every 100ms) a value of the counter may exceed the threshold if the time
between subsequent polls is increased (for whatever reason).
In my opinion the failing assert can be safely removed, since the checks
it perform are quite brittle and cannot be generalized. The assert
violation is affected by CPU performance and sporadic delays between
polls.
For now, instead of assert removal we just avoid checks in-between
memory sample bursts. This way we still can be certain that memory
samples are frequent enough and hopefully this will avoid sporadic
failures.
|
|
present in pexpect match
Problem was observed on UnavailableMultiTest - this test was sporadically failing.
When the failure was observed the log of the failing test looked as follows:
```
File "/whatever/RISCVTests/debug/testlib.py", line 504, in <genexpr>
if all(targets[hart.id]["State"] == "running" for hart in harts):
~~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'State'
```
Adding this modification to testlib.py
```
--- a/debug/testlib.py
+++ b/debug/testlib.py
@@ -498,6 +498,10 @@ class Openocd:
for line in lines[2:]:
if line.strip():
data.append(dict(zip(headers, line.split()[1:])))
+ str_data = str(data)
+ sys.stdout.flush()
+ sys.stdout.write(f"parsed targets:\n{result}\n===\n{str_data}\n---\n")
+ sys.stdout.flush()
return data
```
Allowed me to root cause the issue. Namely we have the following
situation:
```
parsed targets:
Exception ignored in: <function _TemporaryFileCloser.__del__ at 0x7f2dee64d1c0>
Traceback (most recent call last):
File "/usr/local/lib/python3.11/tempfile.py", line 450, in __del__
self.close()
File "/usr/local/lib/python3.11/tempfile.py", line 446, in close
unlink(self.name)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/gdb@38873-8s6ud03x.log'
...
TargetName Type Endian TapName State
-- ------------------ ---------- ------ ------------------ ------------
0 riscv.cpu0 riscv little riscv.cpu running
1* riscv.cpu1 riscv little riscv.cpu running
===
[{'Exception': '"/usr/local/lib/python3.11/tempfile.py",', 'ignored': 'line', 'in:': '450,', ...
```
The only reasonable (to me) explanation for the observed behavior is below.
Here is how we connect to TCL-RPC server:
```
self.openocd_cli = pexpect.spawn(f"nc localhost {self.tclrpc_port}")
tty.setraw(self.openocd_cli.child_fd)
```
Later we request target list by issuing "targets" command:
```
self.command("targets")
```
Internally, pexpect.spawn implemented as follows:
- we fork the process
- set up pty and then call execve
- all these steps are written in python
"Exception ignored" messages are result of exceptions thrown from
finalizers of NamedTemporaryFile objects. When exception is thrown from
the finalizer - python unconditionally prints a "warning" to stderr. It
seems that these messages are polluting our output from "nc" since python
GC can be invoked before the execve syscall.
The workaround is just to make sure that execve was executed before we
rely on the format of command output. To have such a guarantee we just
issue a dummy "echo" command and check that we have a proper reply in the
output stream.
While this explanation looks convincing, the behavior above still looks
strange, given that we have https://bugs.python.org/issue14548 which
was resolved long ago.
However, the proposed workaround fixes the issue.
|
|
Remove old warning check in RepeatReadTest
|
|
debug: Fix nonexistent trigger registers trap handle in entry.S
|
|
Use Ubuntu 20.04 for debug tests
|
|
debug: Fix loading of empty exclude lists with comments
|
|
This patch fixes the case when we are using an empty exception list (for example just a YAML file with comments but without any test items to skip).
|
|
Spike simulator is very demanding to CPU resources. This causes debug
tests to sporadically fail on slower machines. Increasing of gdb's
`remotetimeout` should get rid of such failures, unless we run the
testsuite on a potato.
The only downside is that if OpenOCD is broken, tests can run longer.
However, I think this is the sacrifice we can make, since execution time
is not affected if everything works as expected.
|
|
|
|
Check the mcontrol triggers, no other triggers.
|
|
|
|
Signed-off-by: 梁镇 <zhen.liang@spacemit.com>
Change-Id: I4657a0417b79d515655f6ad4a5ba4465ca58061f
|
|
Clear breakpoints so that gdb will not single step
|
|
improvements to debug tests infrastructure to help with triaging process
|
|
Add virtual memory synchronization after completing the page tables
|
|
Restore $stap and $mstatus after test translate
|
|
See https://github.com/riscv/riscv-debug-spec/blob/f510a7dd33317d0eee0f26b4fa082cd43a5ac7ea/Sdtrig.tex#L213-L214
|
|
Add bitmanip test cases
|
|
Signed-off-by: Roger Chang <rogerycchang@google.com>
|
|
Signed-off-by: Roger Chang <rogerycchang@google.com>
|
|
Signed-off-by: Roger Chang <rogerycchang@google.com>
|
|
Signed-off-by: Roger Chang <rogerycchang@google.com>
|
|
Signed-off-by: liangzhen <zhen.liang@spacemit.com>
Change-Id: Iac914aef8080411e6acd9039c4bdfa728533103c
|
|
If Svnapot is not implemented, skip the test.
|
|
If Svnapot is not implemented, a page fault will occur when accessing a page with napot specified.
In this case, let the test pass.
|
