diff options
author | Evgeniy Naydanov <evgeniy.naydanov@syntacore.com> | 2024-09-16 18:01:17 +0300 |
---|---|---|
committer | Antonio Borneo <borneo.antonio@gmail.com> | 2024-11-11 17:33:56 +0000 |
commit | fd62626dff25cf503a25040d3040b0a2bb9b2a76 (patch) | |
tree | dcd885add7996e53a7e079a9c072a67dfe1306be /git-hooks/commit-msg | |
parent | b68d23da3c3bc67cffc750fddd64a6be9c615fdb (diff) | |
download | riscv-openocd-fd62626dff25cf503a25040d3040b0a2bb9b2a76.zip riscv-openocd-fd62626dff25cf503a25040d3040b0a2bb9b2a76.tar.gz riscv-openocd-fd62626dff25cf503a25040d3040b0a2bb9b2a76.tar.bz2 |
target/breakpoints: fix types in `watchpoint_add_internal()`
There was a conflict:
1. commit 2cd8ebf44d1a ("breakpoints: use 64-bit type for watchpoint mask
and value")
2. commit 0bf3373e808a ("target/breakpoints: Use 'unsigned int' for
length")
The second commit was created erlier, but merged later so the types of
`mask` and `value` became `uint32_t` in `watchpoint_add_internal()`.
This created a bug:
`WATCHPOINT_IGNORE_DATA_VALUE_MASK` is defined as `(~(uint64_t)0)`.
Truncation to uint32_t makes it so the comparisons with the constant
don't work.
Change-Id: I19c414c351f52aff72a60330d83c29db7bbca375
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8500
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Jan Matyas <jan.matyas@codasip.com>
Tested-by: jenkins
Reviewed-by: zapb <dev@zapb.de>
Reviewed-by: Karl Palsson <karlp@tweak.au>
Diffstat (limited to 'git-hooks/commit-msg')
0 files changed, 0 insertions, 0 deletions