Parse isa_string as C-style string

On C++11 and later, std::string is guaranteed to be null-terminated.
However, `*(str.end())` is NOT guaranteed to be '\0'.

So, we parse ISA string using C-style string buffer (raw pointers).

1 files changed, 3 insertions, 2 deletions

diff --git a/riscv/processor.cc b/riscv/processor.cc
index ed9042f..a7b4a5b 100644
--- a/riscv/processor.cc
+++ b/riscv/processor.cc
@@ -221,7 +221,8 @@ void processor_t::parse_isa_string(const char* str)
   if (isa_string[4] != 'i')
     bad_isa_string(str, "'I' extension is required");
 
-  auto p = isa_string.begin();
+  const char* isa_str = isa_string.c_str();
+  auto p = isa_str;
   for (p += 4; islower(*p) && !strchr("zsx", *p); ++p) {
     while (*all_subsets && (*p != *all_subsets))
       ++all_subsets;
@@ -333,7 +334,7 @@ void processor_t::parse_isa_string(const char* str)
     p = end;
   }
   if (*p) {
-    bad_isa_string(str, ("can't parse: " + std::string(p, isa_string.end())).c_str());
+    bad_isa_string(str, ("can't parse: " + std::string(p)).c_str());
   }
 }