diff options
author | Thanos Makatos <thanos.makatos@nutanix.com> | 2019-09-12 04:52:21 -0400 |
---|---|---|
committer | Thanos <tmakatos@gmail.com> | 2019-09-20 14:45:21 +0100 |
commit | fd371160396a565bd32d9240f7c70912504e41ca (patch) | |
tree | 65944804ed7d1b3486bacf4e8beec2bc7878c130 /lib | |
parent | 6cc50a833daa367b8ce0504de8ffb1bc93c47c94 (diff) | |
download | libvfio-user-fd371160396a565bd32d9240f7c70912504e41ca.zip libvfio-user-fd371160396a565bd32d9240f7c70912504e41ca.tar.gz libvfio-user-fd371160396a565bd32d9240f7c70912504e41ca.tar.bz2 |
fix coding style violation rergarding curly bracket
Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/python_bindings.c | 51 |
1 files changed, 17 insertions, 34 deletions
diff --git a/lib/python_bindings.c b/lib/python_bindings.c index f6b2e4a..6091014 100644 --- a/lib/python_bindings.c +++ b/lib/python_bindings.c @@ -61,35 +61,29 @@ region_access_wrap(void *pvt, char * const buf, size_t count, loff_t offset, PyObject *result = NULL; uint64_t _buf = { 0 }; - if (region_access_callbacks[region] == NULL) - { + if (region_access_callbacks[region] == NULL) { fprintf(stderr, "FIXME no callback for region %d\n", region); return -1; } - if (is_write) - { + if (is_write) { memcpy(&_buf, buf, count); } /* FIXME not sure about type of count and offset */ arglist = Py_BuildValue("IKIKi", pvt, _buf, count, offset, is_write); - if (arglist == NULL) - { + if (arglist == NULL) { fprintf(stderr, "FIXME failed to build func args\n"); return -1; } result = PyEval_CallObject(region_access_callbacks[region], arglist); Py_DECREF(arglist); - if (result == NULL) - { + if (result == NULL) { fprintf(stderr, "FIXME failed to call fn for region %d\n", region); return -1; } - if (!is_write) - { - if (handle_read(buf, result, count)) - { + if (!is_write) { + if (handle_read(buf, result, count)) { return -1; } } @@ -144,8 +138,7 @@ static void _log_fn(void *pvt, const char *const msg) arglist = Py_BuildValue("(s)", msg); result = PyEval_CallObject(log_fn, arglist); Py_DECREF(arglist); - if (result != NULL) - { + if (result != NULL) { Py_DECREF(result); } } @@ -180,35 +173,27 @@ libmuser_run(PyObject *self, PyObject *args, PyObject *kwargs) &dev_info.pci_info.irq_count[1], &dev_info.pci_info.irq_count[2], &dev_info.pci_info.irq_count[3], - &dev_info.pci_info.irq_count[4])) - { + &dev_info.pci_info.irq_count[4])) { return NULL; } - for (i = 0; i < LM_DEV_NUM_REGS; i++) - { + for (i = 0; i < LM_DEV_NUM_REGS; i++) { int j; uint32_t flags = 0; - if (i == LM_DEV_CFG_REG_IDX && !memcmp(&_0_ri, &_ri[i], sizeof _0_ri)) - { + if (i == LM_DEV_CFG_REG_IDX && !memcmp(&_0_ri, &_ri[i], sizeof _0_ri)) { continue; } - if (_ri[i].perm != NULL) - { - for (j = 0; j < strlen(_ri[i].perm); j++) - { - if (_ri[i].perm[j] == 'r') - { + if (_ri[i].perm != NULL) { + for (j = 0; j < strlen(_ri[i].perm); j++) { + if (_ri[i].perm[j] == 'r') { flags |= LM_REG_FLAG_READ; } - else if (_ri[i].perm[j] == 'w') - { + else if (_ri[i].perm[j] == 'w') { flags |= LM_REG_FLAG_WRITE; } - else - { + else { /* FIXME shouldn't print to stderr */ fprintf(stderr, "bad permission '%c'\n", _ri[i].perm[j]); return NULL; @@ -221,10 +206,8 @@ libmuser_run(PyObject *self, PyObject *args, PyObject *kwargs) dev_info.pci_info.reg_info[i].fn = region_access_wraps[i]; } - if (log_fn != NULL) - { - if (!PyCallable_Check(log_fn)) - { + if (log_fn != NULL) { + if (!PyCallable_Check(log_fn)) { return NULL; } dev_info.log = _log_fn; |