API error return converged to one func (#325)

* API error return converged to one func

Use ERROR_INT() or ERROR_PTR() to return errors from API's.
This way if we want to change the behaviour later, we will just need
to update these funcitons.
Also fixed some error return cases and comments.

Reviewed-by: John Levon <john.levon@nutanix.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/lib/pci.c b/lib/pci.c
index 78ae459..8d40acb 100644
--- a/lib/pci.c
+++ b/lib/pci.c
@@ -418,12 +418,12 @@ vfu_pci_init(vfu_ctx_t *vfu_ctx, vfu_pci_type_t pci_type,
         break;
     default:
         vfu_log(vfu_ctx, LOG_ERR, "invalid PCI type %u", pci_type);
-        return ERROR(EINVAL);
+        return ERROR_INT(EINVAL);
     }
 
     if (hdr_type != PCI_HEADER_TYPE_NORMAL) {
         vfu_log(vfu_ctx, LOG_ERR, "invalid PCI header type %d", hdr_type);
-        return ERROR(EINVAL);
+        return ERROR_INT(EINVAL);
     }
 
     /*
@@ -433,13 +433,13 @@ vfu_pci_init(vfu_ctx_t *vfu_ctx, vfu_pci_type_t pci_type,
     if (vfu_ctx->pci.config_space != NULL) {
         vfu_log(vfu_ctx, LOG_ERR,
                 "PCI configuration space header already setup");
-        return ERROR(EEXIST);
+        return ERROR_INT(EEXIST);
     }
 
     // Allocate a buffer for the config space.
     cfg_space = calloc(1, size);
     if (cfg_space == NULL) {
-        return ERROR(ENOMEM);
+        return ERROR_INT(ENOMEM);
     }
 
     vfu_ctx->pci.type = pci_type;