diff options
| author | Thanos Makatos <thanos.makatos@nutanix.com> | 2021-06-09 11:15:34 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-06-09 11:15:34 +0100 |
| commit | 1abe697341061a6c16e4a5d28b20b5efa7035a81 (patch) | |
| tree | d034333d573cf5228a03cb9466540a822a60ee20 /include | |
| parent | 57684de8240fce4a277301a86a803842338762af (diff) | |
| download | libvfio-user-1abe697341061a6c16e4a5d28b20b5efa7035a81.zip libvfio-user-1abe697341061a6c16e4a5d28b20b5efa7035a81.tar.gz libvfio-user-1abe697341061a6c16e4a5d28b20b5efa7035a81.tar.bz2 | |
drop mappable flag from DMA map (#553)
The flags field belongs to VFIO and it's not a good idea to reuse as new
VFIO flags can break things. Instead, we derive whether or not a region
is mappable if a file descriptor is passed.
Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Reviewed-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Reviewed-by: John Levon <john.levon@nutanix.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/libvfio-user.h | 3 | ||||
| -rw-r--r-- | include/vfio-user.h | 1 |
2 files changed, 1 insertions, 3 deletions
diff --git a/include/libvfio-user.h b/include/libvfio-user.h index 9c2628a..e05cacf 100644 --- a/include/libvfio-user.h +++ b/include/libvfio-user.h @@ -340,8 +340,7 @@ vfu_setup_device_reset_cb(vfu_ctx_t *vfu_ctx, vfu_reset_cb_t *reset); /* * Info for a guest DMA region. @iova is always valid; the other parameters - * will only be set if the guest DMA region is VFIO_USER_F_DMA_REGION_MAPPABLE, - * and a file descriptor has been passed across the vfio-user socket. + * will only be set if the guest DMA region is mappable. * * @iova: guest DMA range. This is the guest physical range (as we don't * support vIOMMU) that the guest registers for DMA, via a VFIO_USER_DMA_MAP diff --git a/include/vfio-user.h b/include/vfio-user.h index 43f6877..0aca789 100644 --- a/include/vfio-user.h +++ b/include/vfio-user.h @@ -121,7 +121,6 @@ struct vfio_user_dma_map { uint32_t argsz; #define VFIO_USER_F_DMA_REGION_READ (1 << 0) #define VFIO_USER_F_DMA_REGION_WRITE (1 << 1) -#define VFIO_USER_F_DMA_REGION_MAPPABLE (1 << 2) uint32_t flags; uint64_t offset; uint64_t addr; |