diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2013-08-23 17:36:48 +0100 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2013-09-01 19:09:09 +0400 |
| commit | 0bfd22d42b4981e720c502066103c6b658980420 (patch) | |
| tree | 23fc8c429063993094654f369474226b6f78ce9b | |
| parent | 9baa914c3ddf6f9ad2098f889bd0ac0fb71896be (diff) | |
| download | slirp-0bfd22d42b4981e720c502066103c6b658980420.zip slirp-0bfd22d42b4981e720c502066103c6b658980420.tar.gz slirp-0bfd22d42b4981e720c502066103c6b658980420.tar.bz2 | |
slirp/arp_table.c: Avoid shifting into sign bit of signed integers
"0xf << 28" shifts right into the sign bit, since 0xf is a signed
integer. Use the 'U' suffix to force an unsigned shift to avoid
this undefined behaviour and a clang sanitizer warning.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | arp_table.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arp_table.c b/arp_table.c index 188c2af..b0f7081 100644 --- a/arp_table.c +++ b/arp_table.c @@ -37,7 +37,7 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN]) ethaddr[1], ethaddr[2], ethaddr[3], ethaddr[4], ethaddr[5])); /* Check 0.0.0.0/8 invalid source-only addresses */ - if ((ip_addr & htonl(~(0xf << 28))) == 0) { + if ((ip_addr & htonl(~(0xfU << 28))) == 0) { return; } @@ -73,7 +73,7 @@ bool arp_table_search(Slirp *slirp, uint32_t ip_addr, DEBUG_ARG("ip = 0x%x", ip_addr); /* Check 0.0.0.0/8 invalid source-only addresses */ - assert((ip_addr & htonl(~(0xf << 28))) != 0); + assert((ip_addr & htonl(~(0xfU << 28))) != 0); /* If broadcast address */ if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) { |