From 0bfd22d42b4981e720c502066103c6b658980420 Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Fri, 23 Aug 2013 17:36:48 +0100 Subject: slirp/arp_table.c: Avoid shifting into sign bit of signed integers "0xf << 28" shifts right into the sign bit, since 0xf is a signed integer. Use the 'U' suffix to force an unsigned shift to avoid this undefined behaviour and a clang sanitizer warning. Signed-off-by: Peter Maydell Reviewed-by: Eric Blake Acked-by: Jan Kiszka Signed-off-by: Michael Tokarev --- arp_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arp_table.c b/arp_table.c index 188c2af..b0f7081 100644 --- a/arp_table.c +++ b/arp_table.c @@ -37,7 +37,7 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN]) ethaddr[1], ethaddr[2], ethaddr[3], ethaddr[4], ethaddr[5])); /* Check 0.0.0.0/8 invalid source-only addresses */ - if ((ip_addr & htonl(~(0xf << 28))) == 0) { + if ((ip_addr & htonl(~(0xfU << 28))) == 0) { return; } @@ -73,7 +73,7 @@ bool arp_table_search(Slirp *slirp, uint32_t ip_addr, DEBUG_ARG("ip = 0x%x", ip_addr); /* Check 0.0.0.0/8 invalid source-only addresses */ - assert((ip_addr & htonl(~(0xf << 28))) != 0); + assert((ip_addr & htonl(~(0xfU << 28))) != 0); /* If broadcast address */ if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) { -- cgit v1.1