diff options
| author | Pali Rohár <pali@kernel.org> | 2023-01-08 23:28:39 +0100 |
|---|---|---|
| committer | Stefan Roese <sr@denx.de> | 2023-03-01 06:39:17 +0100 |
| commit | 2f6855a6aa8d55d8341f454f87cabc784a890193 (patch) | |
| tree | c714974d2696e549c0cb5d762cf9f1b3144d9f08 /tools/mkimage.c | |
| parent | cccc5b4f3d06dd2b021eaf690f8f828c3d4c9af5 (diff) | |
| download | u-boot-2f6855a6aa8d55d8341f454f87cabc784a890193.zip u-boot-2f6855a6aa8d55d8341f454f87cabc784a890193.tar.gz u-boot-2f6855a6aa8d55d8341f454f87cabc784a890193.tar.bz2 | |
tools: mkimage: Print human readable error when -d is not specified
When asking mkimage to create a new image file and option -d is not
specified then mkimage show human unfriendly error message:
mkimage: Can't open (null): Bad address
Without debugger it is hard to debug what is the issue. Function open() is
being called with file name set to NULL. So add a check for this and if it
happens then show human readable message that option -d was not specified.
Signed-off-by: Pali Rohár <pali@kernel.org>
Diffstat (limited to 'tools/mkimage.c')
| -rw-r--r-- | tools/mkimage.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tools/mkimage.c b/tools/mkimage.c index 0b34215..5e0bb91 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -600,6 +600,11 @@ int main(int argc, char **argv) } if ((params.type != IH_TYPE_MULTI) && (params.type != IH_TYPE_SCRIPT)) { + if (!params.datafile) { + fprintf(stderr, "%s: Option -d with image data file was not specified\n", + params.cmdname); + exit(EXIT_FAILURE); + } dfd = open(params.datafile, O_RDONLY | O_BINARY); if (dfd < 0) { fprintf(stderr, "%s: Can't open %s: %s\n", |