diff options
| author | AKASHI Takahiro <takahiro.akashi@linaro.org> | 2023-10-11 19:06:54 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2023-10-13 16:59:23 -0400 |
| commit | c6230cd8427c906baa52dbff5b95027ef58e6048 (patch) | |
| tree | 3a1ca7d9de802439e9d702ebdad90066f0f8a173 /include | |
| parent | ab9fbac81670478feccd439a5d84a67bd14d581d (diff) | |
| download | u-boot-c6230cd8427c906baa52dbff5b95027ef58e6048.zip u-boot-c6230cd8427c906baa52dbff5b95027ef58e6048.tar.gz u-boot-c6230cd8427c906baa52dbff5b95027ef58e6048.tar.bz2 | |
scmi: refactor the code to hide a channel from devices
The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
reference") added an explicit parameter, channel, but it seems to make
the code complex.
Hiding this parameter will allow for adding a generic (protocol-agnostic)
helper function, i.e. for PROTOCOL_VERSION, in a later patch.
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/scmi_agent.h | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/include/scmi_agent.h b/include/scmi_agent.h index ee62863..5778920 100644 --- a/include/scmi_agent.h +++ b/include/scmi_agent.h @@ -15,6 +15,14 @@ struct udevice; struct scmi_channel; +/** + * struct scmi_agent_proto_priv - Private data in device for SCMI agent + * @channel: Reference to the SCMI channel to use + */ +struct scmi_agent_proto_priv { + struct scmi_channel *channel; +}; + /* * struct scmi_msg - Context of a SCMI message sent and the response received * @@ -49,10 +57,9 @@ struct scmi_msg { * devm_scmi_of_get_channel() - Get SCMI channel handle from SCMI agent DT node * * @dev: Device requesting a channel - * @channel: Output reference to the SCMI channel upon success * @return 0 on success and a negative errno on failure */ -int devm_scmi_of_get_channel(struct udevice *dev, struct scmi_channel **channel); +int devm_scmi_of_get_channel(struct udevice *dev); /** * devm_scmi_process_msg() - Send and process an SCMI message @@ -62,12 +69,10 @@ int devm_scmi_of_get_channel(struct udevice *dev, struct scmi_channel **channel) * On return, scmi_msg::out_msg_sz stores the response payload size. * * @dev: SCMI device - * @channel: Communication channel for the device * @msg: Message structure reference * Return: 0 on success and a negative errno on failure */ -int devm_scmi_process_msg(struct udevice *dev, struct scmi_channel *channel, - struct scmi_msg *msg); +int devm_scmi_process_msg(struct udevice *dev, struct scmi_msg *msg); /** * scmi_to_linux_errno() - Convert an SCMI error code into a Linux errno code |