diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/samsung | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.zip u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.bz2 |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/samsung')
-rw-r--r-- | board/samsung/arndale/arndale.c | 2 | ||||
-rw-r--r-- | board/samsung/common/board.c | 2 | ||||
-rw-r--r-- | board/samsung/goni/goni.c | 2 | ||||
-rw-r--r-- | board/samsung/smdkc100/smdkc100.c | 2 | ||||
-rw-r--r-- | board/samsung/smdkv310/smdkv310.c | 4 |
5 files changed, 6 insertions, 6 deletions
diff --git a/board/samsung/arndale/arndale.c b/board/samsung/arndale/arndale.c index 7a8e57b..9181376 100644 --- a/board/samsung/arndale/arndale.c +++ b/board/samsung/arndale/arndale.c @@ -74,7 +74,7 @@ int dram_init_banksize(void) } #ifdef CONFIG_MMC -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int ret; /* dwmmc initializattion for available channels */ diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c index 029a0cc..752d84e 100644 --- a/board/samsung/common/board.c +++ b/board/samsung/common/board.c @@ -220,7 +220,7 @@ static int decode_sromc(const void *blob, struct fdt_sromc *config) } #endif -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { #ifdef CONFIG_SMC911X u32 smc_bw_conf, smc_bc_conf; diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c index 40a94d5..2f0ef22 100644 --- a/board/samsung/goni/goni.c +++ b/board/samsung/goni/goni.c @@ -76,7 +76,7 @@ int checkboard(void) #endif #ifdef CONFIG_MMC -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int i, ret, ret_sd = 0; diff --git a/board/samsung/smdkc100/smdkc100.c b/board/samsung/smdkc100/smdkc100.c index fc2c2a9..d034f53 100644 --- a/board/samsung/smdkc100/smdkc100.c +++ b/board/samsung/smdkc100/smdkc100.c @@ -69,7 +69,7 @@ int checkboard(void) } #endif -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_SMC911X diff --git a/board/samsung/smdkv310/smdkv310.c b/board/samsung/smdkv310/smdkv310.c index 0a57736..24273f1 100644 --- a/board/samsung/smdkv310/smdkv310.c +++ b/board/samsung/smdkv310/smdkv310.c @@ -72,7 +72,7 @@ int dram_init_banksize(void) return 0; } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_SMC911X @@ -90,7 +90,7 @@ int checkboard(void) #endif #ifdef CONFIG_MMC -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int i, err; |