diff options
| author | Patrick Delaunay <patrick.delaunay@st.com> | 2020-02-12 19:37:37 +0100 |
|---|---|---|
| committer | Patrick Delaunay <patrick.delaunay@st.com> | 2020-03-24 14:05:35 +0100 |
| commit | df2d1b8fc472bd0c7ec20d86337d437241d9b013 (patch) | |
| tree | 54d953e625ad36cd91ec2eca428582e0c6fb3e6f | |
| parent | fdabacecf0af242d92e312faa4df6c24857f8935 (diff) | |
| download | u-boot-df2d1b8fc472bd0c7ec20d86337d437241d9b013.zip u-boot-df2d1b8fc472bd0c7ec20d86337d437241d9b013.tar.gz u-boot-df2d1b8fc472bd0c7ec20d86337d437241d9b013.tar.bz2 | |
arm: stm32mp: bsec: remove unneeded test
Remove the test offs < 0 , as offs is unsigned.
This patch solves the warnings when compiling with W=1
on stm32mp1 board:
In function ‘stm32mp_bsec_read’:
arch/arm/mach-stm32mp/bsec.c:368:11: warning:
comparison of unsigned expression < 0 is always false [-Wtype-limits]
368 | if (offs < 0 || (offs % 4) || (size % 4))
| ^
In function ‘stm32mp_bsec_write’:
arch/arm/mach-stm32mp/bsec.c:405:11: warning:
comparison of unsigned expression < 0 is always false [-Wtype-limits]
405 | if (offs < 0 || (offs % 4) || (size % 4))
| ^
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
| -rw-r--r-- | arch/arm/mach-stm32mp/bsec.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c index a77c706..1d904ca 100644 --- a/arch/arm/mach-stm32mp/bsec.c +++ b/arch/arm/mach-stm32mp/bsec.c @@ -365,7 +365,7 @@ static int stm32mp_bsec_read(struct udevice *dev, int offset, shadow = false; } - if (offs < 0 || (offs % 4) || (size % 4)) + if ((offs % 4) || (size % 4)) return -EINVAL; otp = offs / sizeof(u32); @@ -402,7 +402,7 @@ static int stm32mp_bsec_write(struct udevice *dev, int offset, shadow = false; } - if (offs < 0 || (offs % 4) || (size % 4)) + if ((offs % 4) || (size % 4)) return -EINVAL; otp = offs / sizeof(u32); |