diff options
| author | Simon Glass <sjg@chromium.org> | 2017-06-07 10:28:44 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2017-06-12 08:38:10 -0400 |
| commit | 4f414d392fb5d7c4ac547c4ee9f02b81648c00dd (patch) | |
| tree | b224d8442f1822a9c260f9d14e9b56ffe3fc0224 | |
| parent | 9eace7f59ee4a37a678e4b57dc3fe532283f9226 (diff) | |
| download | u-boot-4f414d392fb5d7c4ac547c4ee9f02b81648c00dd.zip u-boot-4f414d392fb5d7c4ac547c4ee9f02b81648c00dd.tar.gz u-boot-4f414d392fb5d7c4ac547c4ee9f02b81648c00dd.tar.bz2 | |
test: bus: Add a check that dev is not NULL
We know that uclass_get_device() and device_find_child_by_of_offset() do
not return NULL for dev when they succeeds but coverity does not. Add an
extra check to hopefully keep it happy.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163246)
Fixes: 0753bc2 (dm: Simple Watchdog uclass)
| -rw-r--r-- | test/dm/bus.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/dm/bus.c b/test/dm/bus.c index 8ba75d4..7006d41 100644 --- a/test/dm/bus.c +++ b/test/dm/bus.c @@ -171,13 +171,16 @@ static int dm_test_bus_children_of_offset(struct unit_test_state *uts) int node; ut_assertok(uclass_get_device(UCLASS_TEST_BUS, 0, &bus)); + ut_assertnonnull(bus); /* Find a valid child */ node = fdt_path_offset(blob, "/some-bus/c-test@1"); ut_assert(node > 0); ut_assertok(device_find_child_by_of_offset(bus, node, &dev)); + ut_assertnonnull(dev); ut_assert(!(dev->flags & DM_FLAG_ACTIVATED)); ut_assertok(device_get_child_by_of_offset(bus, node, &dev)); + ut_assertnonnull(dev); ut_assert(dev->flags & DM_FLAG_ACTIVATED); return 0; |