diff options
| author | Michael Brown <mcb30@ipxe.org> | 2024-04-18 11:25:58 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2024-04-18 11:25:58 +0100 |
| commit | 5215be29014efba9342cd96daf3fd2d74a963871 (patch) | |
| tree | 496730b89aabf920a47f25226c46fd7ded2c9aec | |
| parent | d7e58c5a812988c341ec4ad19f79faf067388d58 (diff) | |
| download | ipxe-coverity_scan.zip ipxe-coverity_scan.tar.gz ipxe-coverity_scan.tar.bz2 | |
[readline] Silence spurious null pointer dereference Coverity warningcoverity_scan
Coverity reported a potential null pointer dereference in readline.c,
which was fixed in commit b01781a ("[hci] Fix semantics of
replace_string() to match code comments"). With the fix in place,
Coverity still reports a potential null pointer dereference, even
though this cannot now happen.
Add an assertion to inform Coverity that the allocated string cannot
be NULL after a successful call to replace_string().
Signed-off-by: Michael Brown <mcb30@ipxe.org>
| -rw-r--r-- | src/hci/readline.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/hci/readline.c b/src/hci/readline.c index 5b46413..3c5f924 100644 --- a/src/hci/readline.c +++ b/src/hci/readline.c @@ -278,6 +278,7 @@ int readline_history ( const char *prompt, const char *prefill, /* Prefill string */ if ( ( rc = replace_string ( &string, prefill ) ) != 0 ) goto error; + assert ( *line != NULL ); sync_console ( &string ); while ( 1 ) { |