aboutsummaryrefslogtreecommitdiff
path: root/tool
diff options
context:
space:
mode:
authorDavid Benjamin <davidben@google.com>2023-02-05 13:44:26 -0500
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-02-14 21:00:31 +0000
commit8c75ed046f799f1d8b805036b1dea9c5ec0a0fb5 (patch)
tree1fbafb4f3f3150eaba7bd7611812c0ba2d9a48f4 /tool
parente5f7266884922dd66fb07a92570102ff2f5d912f (diff)
downloadboringssl-8c75ed046f799f1d8b805036b1dea9c5ec0a0fb5.zip
boringssl-8c75ed046f799f1d8b805036b1dea9c5ec0a0fb5.tar.gz
boringssl-8c75ed046f799f1d8b805036b1dea9c5ec0a0fb5.tar.bz2
Remove global_target from build.
This was added with the generated symbol-prefixing header. But it seems to be sufficient for crypto to have a dependency on the generated header, along with some of the stray bits of delocate. It's a little unclear from CMake documentation how these are processed; normally .o files can be built before libraries are built or linked, only the link step depends on. But, empirically, if A links B, and B has a dependency on C, then CMake seems to run C before building any of A. I tested this by making a small project where the generation step slept for three seconds and running with enough parallelism that we'd have tripped. Interestingly, in the Makefile output, the individual object file targets didn't have that dependency, but the target itself did. But this was true on both A and B, so I think that just might not work. Also fix the dependency in the custom target. The old formulation broke when using an absolute path to the symbols file. Change-Id: I2053d44949f907d465da403a5ec69c191740268f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56928 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
Diffstat (limited to 'tool')
-rw-r--r--tool/CMakeLists.txt1
1 files changed, 0 insertions, 1 deletions
diff --git a/tool/CMakeLists.txt b/tool/CMakeLists.txt
index df5d9a7..5047108 100644
--- a/tool/CMakeLists.txt
+++ b/tool/CMakeLists.txt
@@ -20,5 +20,4 @@ add_executable(
transport_common.cc
)
install_if_enabled(TARGETS bssl DESTINATION ${INSTALL_DESTINATION_DEFAULT})
-add_dependencies(bssl global_target)
target_link_libraries(bssl ssl crypto)