diff options
| author | David Benjamin <davidben@google.com> | 2017-10-11 20:48:25 -0400 |
|---|---|---|
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | 2017-10-17 21:19:31 +0000 |
| commit | a031b61230a0f19a5e34acc3874528d804b181c7 (patch) | |
| tree | b08b7351e9c0949c099fbbcd6b29048f3c534280 /ssl/tls_method.cc | |
| parent | e8d0746b88621962d8e4959f0fd8130c18932bb5 (diff) | |
| download | boringssl-a031b61230a0f19a5e34acc3874528d804b181c7.zip boringssl-a031b61230a0f19a5e34acc3874528d804b181c7.tar.gz boringssl-a031b61230a0f19a5e34acc3874528d804b181c7.tar.bz2 | |
Replace open_close_notify with open_app_data.
While a fairly small hook, open_close_notify is pretty weird. It
processes things at the record level and not above. Notably, this will
break if it skips past a TLS 1.3 KeyUpdate.
Instead, it can share the core part of SSL_read/SSL_peek, with slight
tweaks to post-handshake processing. Note this does require some tweaks
to that code. Notably, to retain the current semantics that SSL_shutdown
does not call funny callbacks, we suppress tickets.
Change-Id: Ia0cbd0b9f4527f1b091dd2083a5d8c7efb2bac65
Reviewed-on: https://boringssl-review.googlesource.com/21885
Commit-Queue: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
Reviewed-by: Steven Valdez <svaldez@google.com>
Diffstat (limited to 'ssl/tls_method.cc')
| -rw-r--r-- | ssl/tls_method.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ssl/tls_method.cc b/ssl/tls_method.cc index c7352ce..94b9e20 100644 --- a/ssl/tls_method.cc +++ b/ssl/tls_method.cc @@ -116,7 +116,6 @@ static const SSL_PROTOCOL_METHOD kTLSProtocolMethod = { ssl3_open_handshake, ssl3_open_change_cipher_spec, ssl3_open_app_data, - ssl3_open_close_notify, ssl3_write_app_data, ssl3_dispatch_alert, ssl3_supports_cipher, |