aboutsummaryrefslogtreecommitdiff
path: root/fuzz
diff options
context:
space:
mode:
authorDavid Benjamin <davidben@google.com>2016-12-14 18:52:21 -0500
committerAdam Langley <agl@google.com>2016-12-16 19:11:02 +0000
commit65fb4258114dc30c4cb9c4636b1432214cb40683 (patch)
tree13c7944d628d5cf308dd2dcb69a64061da901acb /fuzz
parent2d5848200404b2773c35bb1aa00dc3edd7a829d9 (diff)
downloadboringssl-65fb4258114dc30c4cb9c4636b1432214cb40683.zip
boringssl-65fb4258114dc30c4cb9c4636b1432214cb40683.tar.gz
boringssl-65fb4258114dc30c4cb9c4636b1432214cb40683.tar.bz2
Remove version-specific cipher lists.
There are no longer any consumers of these APIs. These were useful back when the CBC vs. RC4 tradeoff varied by version and it was worth carefully tuning this cutoff. Nowadays RC4 is completely gone and there's no use in configuring these anymore. To avoid invalidating the existing ssl_ctx_api corpus and requiring it regenerated, I've left the entries in there. It's probably reasonable for new API fuzzers to reuse those slots. Change-Id: I02bf950e3828062341e4e45c8871a44597ae93d5 Reviewed-on: https://boringssl-review.googlesource.com/12880 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'fuzz')
-rw-r--r--fuzz/ssl_ctx_api.cc14
1 files changed, 4 insertions, 10 deletions
diff --git a/fuzz/ssl_ctx_api.cc b/fuzz/ssl_ctx_api.cc
index a66b1a8..b721c6b 100644
--- a/fuzz/ssl_ctx_api.cc
+++ b/fuzz/ssl_ctx_api.cc
@@ -347,18 +347,12 @@ static const std::function<void(SSL_CTX *, CBS *)> kAPIs[] = {
SSL_CTX_set_cipher_list(ctx, ciphers.c_str());
},
[](SSL_CTX *ctx, CBS *cbs) {
- std::string ciphers;
- if (!GetString(&ciphers, cbs)) {
- return;
- }
- SSL_CTX_set_cipher_list_tls10(ctx, ciphers.c_str());
+ // This function was left blank rather than removed to avoid invalidating
+ // the existing corpus. New entries may reuse it.
},
[](SSL_CTX *ctx, CBS *cbs) {
- std::string ciphers;
- if (!GetString(&ciphers, cbs)) {
- return;
- }
- SSL_CTX_set_cipher_list_tls11(ctx, ciphers.c_str());
+ // This function was left blank rather than removed to avoid invalidating
+ // the existing corpus. New entries may reuse it.
},
[](SSL_CTX *ctx, CBS *cbs) {
std::string ciphers;