diff options
author | David Benjamin <davidben@google.com> | 2022-12-03 17:45:02 -0500 |
---|---|---|
committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-12-09 02:23:13 +0000 |
commit | faac9aa3349f149cd433582c31020d49090a0737 (patch) | |
tree | 9b94ae6ccb53475a34f4fe8f77ba4b815644a8fa /decrepit/ripemd | |
parent | 1e63b0ce530a748ef564014c3cb111b1161c89fd (diff) | |
download | boringssl-faac9aa3349f149cd433582c31020d49090a0737.zip boringssl-faac9aa3349f149cd433582c31020d49090a0737.tar.gz boringssl-faac9aa3349f149cd433582c31020d49090a0737.tar.bz2 |
Finish porting dh_test.cc and ripemd_test.cc to GTest.
They're the only two half-finished ports left, so we may as well finish
that up and trim them down a little.
Change-Id: Ic058124a44086161ab5d2d6fa24448492c3ba219
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55506
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
Diffstat (limited to 'decrepit/ripemd')
-rw-r--r-- | decrepit/ripemd/ripemd_test.cc | 25 |
1 files changed, 5 insertions, 20 deletions
diff --git a/decrepit/ripemd/ripemd_test.cc b/decrepit/ripemd/ripemd_test.cc index 0700bae..6338fec 100644 --- a/decrepit/ripemd/ripemd_test.cc +++ b/decrepit/ripemd/ripemd_test.cc @@ -57,17 +57,13 @@ static const RIPEMDTestCase kRIPEMDTestCases[] = { // TODO(davidben): Convert this file to GTest properly. TEST(RIPEMDTest, RunTest) { - unsigned test_num = 0; - int ok = 1; - for (const auto &test : kRIPEMDTestCases) { - test_num++; - + SCOPED_TRACE(test.input); const size_t input_len = strlen(test.input); for (size_t stride = 0; stride <= input_len; stride++) { + SCOPED_TRACE(stride); uint8_t digest[RIPEMD160_DIGEST_LENGTH]; - if (stride == 0) { RIPEMD160(reinterpret_cast<const uint8_t *>(test.input), input_len, digest); @@ -89,12 +85,7 @@ TEST(RIPEMDTest, RunTest) { RIPEMD160_Final(digest, &ctx); } - if (OPENSSL_memcmp(digest, test.expected, sizeof(digest)) != 0) { - fprintf(stderr, "#%u: bad result with stride %u: ", test_num, - static_cast<unsigned>(stride)); - hexdump(stderr, "", digest, sizeof(digest)); - ok = 0; - } + EXPECT_EQ(Bytes(digest), Bytes(test.expected)); } } @@ -107,12 +98,6 @@ TEST(RIPEMDTest, RunTest) { static const uint8_t kMillionADigest[RIPEMD160_DIGEST_LENGTH] = { 0x52, 0x78, 0x32, 0x43, 0xc1, 0x69, 0x7b, 0xdb, 0xe1, 0x6d, 0x37, 0xf9, 0x7f, 0x68, 0xf0, 0x83, 0x25, 0xdc, 0x15, 0x28}; - - if (OPENSSL_memcmp(digest, kMillionADigest, sizeof(digest)) != 0) { - fprintf(stderr, u8"Digest incorrect for “million a's” test: "); - hexdump(stderr, "", digest, sizeof(digest)); - ok = 0; - } - - EXPECT_EQ(1, ok); + EXPECT_EQ(Bytes(digest), Bytes(kMillionADigest)) + << "Digest incorrect for \"million a's\" test"; } |