diff options
| author | David Benjamin <davidben@google.com> | 2024-03-18 22:43:46 +1000 |
|---|---|---|
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-03-23 14:43:15 +0000 |
| commit | 3ae23976862fa9036ab52e47c8a22025f5d76ca0 (patch) | |
| tree | 32196be50aa78eb420ef15854d2b373dee526021 /build.json | |
| parent | 231510cf506711eae6f7f06be9626bc7e44982b4 (diff) | |
| download | boringssl-3ae23976862fa9036ab52e47c8a22025f5d76ca0.zip boringssl-3ae23976862fa9036ab52e47c8a22025f5d76ca0.tar.gz boringssl-3ae23976862fa9036ab52e47c8a22025f5d76ca0.tar.bz2 | |
Rework the test data story
We originally embedded test data because of deficiencies in Android's
build. Android had no way to specify test data with tests. That has
since been resolved, and the embedding mechanism has gotten unwieldy.
This unifies pki_test and crypto_test's test data story, and does so in
a way that all tests can participate in. (We can now use FileTest in
decrepit_test.)
Update-Note: This will require some tweaks to downstream builds. We no
longer emit an (unwieldy) crypto_test_data.cc file. Instead, tests will
expect test data be available at the current working directory. This can
be overridden with the BORINGSSL_TEST_DATA_ROOT environment variable.
Callers with more complex needs can build with
BORINGSSL_CUSTOM_GET_TEST_DATA and then link in an alternate
implementation of this function.
On the off chance some project needs it, I've kept the
embed_test_data.go script around for now, but I expect we can delete it
in the future.
Fixed: 681
Change-Id: If181ce043e1eea3148838f1bb4db9ee4bfda0d08
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/67295
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
Diffstat (limited to 'build.json')
| -rw-r--r-- | build.json | 6 |
1 files changed, 2 insertions, 4 deletions
@@ -202,7 +202,9 @@ "srcs": [ "crypto/test/abi_test.cc", "crypto/test/file_test.cc", + "crypto/test/file_test_gtest.cc", "crypto/test/file_util.cc", + "crypto/test/test_data.cc", "crypto/test/test_util.cc", "crypto/test/wycheproof_util.cc" ], @@ -285,10 +287,6 @@ "crypto/siphash/siphash_test.cc", "crypto/spx/spx_test.cc", "crypto/thread_test.cc", - // TODO(crbug.com/boringssl/542): This should be in test_support, so - // that all tests can use it. But it depends on GetTestData, which - // is not currently usable outside of crypto_test. - "crypto/test/file_test_gtest.cc", "crypto/test/gtest_main.cc", "crypto/trust_token/trust_token_test.cc", "crypto/x509/tab_test.cc", |