diff options
| author | Thomas Huth <thuth@linux.vnet.ibm.com> | 2011-12-28 18:30:50 +0100 |
|---|---|---|
| committer | Thomas Huth <thuth@linux.vnet.ibm.com> | 2011-12-28 18:38:39 +0100 |
| commit | 8536acbc9f7b527d72011110ec15baa85ed278a8 (patch) | |
| tree | d1187d080ef3cae1343bbd4b10a0967ed9b39e3e /clients | |
| parent | 23c9ac89811b6c01f6f54860eeb3c77252a3b6a8 (diff) | |
| download | SLOF-8536acbc9f7b527d72011110ec15baa85ed278a8.zip SLOF-8536acbc9f7b527d72011110ec15baa85ed278a8.tar.gz SLOF-8536acbc9f7b527d72011110ec15baa85ed278a8.tar.bz2 | |
Enabled -Wmissing-prototypes and -Wstrict-prototypes CFLAGS and cleaned up
These two compiler flags for additional warnings help to improve the quality
of the source code: Removed some unused code and fixed some obvious bugs.
Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Diffstat (limited to 'clients')
| -rw-r--r-- | clients/net-snk/oflib/ci_device.c | 1 | ||||
| -rw-r--r-- | clients/takeover/main.c | 9 | ||||
| -rw-r--r-- | clients/takeover/takeover.h | 2 |
3 files changed, 8 insertions, 4 deletions
diff --git a/clients/net-snk/oflib/ci_device.c b/clients/net-snk/oflib/ci_device.c index ef47c22..0bca6f8 100644 --- a/clients/net-snk/oflib/ci_device.c +++ b/clients/net-snk/oflib/ci_device.c @@ -35,6 +35,7 @@ extern snk_kernel_t snk_kernel_interface; +snk_module_t * cimod_check_and_install(void); static int cimod_init(void); static int cimod_term(void); static int cimod_read(char *buffer, int len); diff --git a/clients/takeover/main.c b/clients/takeover/main.c index 40e630b..83048bb 100644 --- a/clients/takeover/main.c +++ b/clients/takeover/main.c @@ -16,11 +16,14 @@ #include <of.h> #include <pci.h> #include <cpu.h> +#include <ioctl.h> #include <takeover.h> extern void call_client_interface(of_arg_t *); extern void m_sync(void); +int callback(int argc, char *argv[]); + #define boot_rom_bin_start _binary_______boot_rom_bin_start #define boot_rom_bin_end _binary_______boot_rom_bin_end @@ -101,7 +104,7 @@ sbrk(int incr) return (void *) -1; } -void +static void doWait(void) { static const char *wheel = "|/-\\"; @@ -113,7 +116,7 @@ doWait(void) i &= 0x3; } -void +static void quiesce(void) { of_arg_t arg = { @@ -123,7 +126,7 @@ quiesce(void) call_client_interface(&arg); } -int +static int startCpu(int num, int addr, int reg) { of_arg_t arg = { diff --git a/clients/takeover/takeover.h b/clients/takeover/takeover.h index 1949f71..f348e23 100644 --- a/clients/takeover/takeover.h +++ b/clients/takeover/takeover.h @@ -19,5 +19,5 @@ #endif #ifndef __ASSEMBLER__ -int takeover(); +int takeover(void); #endif |