aboutsummaryrefslogtreecommitdiff
path: root/unittests
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2021-11-19 10:39:21 -0800
committerDylan Baker <dylan@pnwbakers.com>2021-11-22 12:24:14 -0800
commitecc47d67a945760c3d5e739581fa984bfea6a840 (patch)
tree8bf93ff2ef715e9f41d010bd77af76b7ba56eb10 /unittests
parent1f6351461c5d3654aeff2355c96fe54bb28469f8 (diff)
downloadmeson-ecc47d67a945760c3d5e739581fa984bfea6a840.zip
meson-ecc47d67a945760c3d5e739581fa984bfea6a840.tar.gz
meson-ecc47d67a945760c3d5e739581fa984bfea6a840.tar.bz2
typed_kwargs: provide better error messages for wrong container types
Currently, if you pass a `[]string`, but the argument expects `[]number`, then you get a message like `expected list[str] but got list`. That isn't helpful. With this patch arrays and dictionaries will both print messages with the types provided.
Diffstat (limited to 'unittests')
-rw-r--r--unittests/internaltests.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/unittests/internaltests.py b/unittests/internaltests.py
index 207bd37..86c1890 100644
--- a/unittests/internaltests.py
+++ b/unittests/internaltests.py
@@ -1266,7 +1266,7 @@ class InternalTests(unittest.TestCase):
with self.assertRaises(InvalidArguments) as cm:
_(None, mock.Mock(), [], {'input': {}})
- self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type 'dict' but should have been list[str]")
+ self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type dict[] but should have been list[str]")
def test_typed_kwarg_contained_invalid(self) -> None:
@typed_kwargs(
@@ -1278,7 +1278,7 @@ class InternalTests(unittest.TestCase):
with self.assertRaises(InvalidArguments) as cm:
_(None, mock.Mock(), [], {'input': {'key': 1}})
- self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type 'dict' but should have been dict[str]")
+ self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type dict[int] but should have been dict[str]")
def test_typed_kwarg_container_listify(self) -> None:
@typed_kwargs(
@@ -1313,7 +1313,7 @@ class InternalTests(unittest.TestCase):
with self.assertRaises(MesonException) as cm:
_(None, mock.Mock(), [], {'input': ['a']})
- self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type 'list' but should have been list[str] that has even size")
+ self.assertEqual(str(cm.exception), "testfunc keyword argument 'input' was of type list[str] but should have been list[str] that has even size")
@mock.patch.dict(mesonbuild.mesonlib.project_meson_versions, {})
def test_typed_kwarg_since(self) -> None: