diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2023-07-03 12:25:29 -0400 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2023-07-19 18:31:36 -0400 |
| commit | 3171fc533812e15bcb5eda607c7c82d37d0aaf42 (patch) | |
| tree | d570c1e52e50df39a33360d59d36589c0027796f /mesonbuild | |
| parent | 4fab71f48144cd6760ceae5c3085e68e93b9016f (diff) | |
| download | meson-3171fc533812e15bcb5eda607c7c82d37d0aaf42.zip meson-3171fc533812e15bcb5eda607c7c82d37d0aaf42.tar.gz meson-3171fc533812e15bcb5eda607c7c82d37d0aaf42.tar.bz2 | |
add better comments for mypy suppressions
Diffstat (limited to 'mesonbuild')
| -rw-r--r-- | mesonbuild/modules/gnome.py | 4 | ||||
| -rw-r--r-- | mesonbuild/modules/pkgconfig.py | 1 |
2 files changed, 3 insertions, 2 deletions
diff --git a/mesonbuild/modules/gnome.py b/mesonbuild/modules/gnome.py index 7a9acea..755bf24 100644 --- a/mesonbuild/modules/gnome.py +++ b/mesonbuild/modules/gnome.py @@ -1744,7 +1744,7 @@ class GnomeModule(ExtensionModule): 'identifier_prefix', 'symbol_prefix', 'vhead', 'vprod', 'vtail'] for arg in known_kwargs: - # mypy can't figure this out + # Mypy can't figure out that this TypedDict index is correct, without repeating T.Literal for the entire list if kwargs[arg]: # type: ignore cmd += ['--' + arg.replace('_', '-'), kwargs[arg]] # type: ignore @@ -1966,7 +1966,7 @@ class GnomeModule(ExtensionModule): mlog.bold('https://github.com/mesonbuild/meson/pull/2049'), once=True, fatal=False) for k in ['internal', 'nostdinc', 'skip_source', 'stdinc', 'valist_marshallers']: - # Mypy can't figure out that this is correct + # Mypy can't figure out that this TypedDict index is correct, without repeating T.Literal for the entire list if kwargs[k]: # type: ignore cmd.append(f'--{k.replace("_", "-")}') diff --git a/mesonbuild/modules/pkgconfig.py b/mesonbuild/modules/pkgconfig.py index 921fb66..9f71d95 100644 --- a/mesonbuild/modules/pkgconfig.py +++ b/mesonbuild/modules/pkgconfig.py @@ -649,6 +649,7 @@ class PkgConfigModule(NewExtensionModule): if dataonly: default_subdirs = [] blocked_vars = ['libraries', 'libraries_private', 'requires_private', 'extra_cflags', 'subdirs'] + # Mypy can't figure out that this TypedDict index is correct, without repeating T.Literal for the entire list if any(kwargs[k] for k in blocked_vars): # type: ignore raise mesonlib.MesonException(f'Cannot combine dataonly with any of {blocked_vars}') default_install_dir = os.path.join(state.environment.get_datadir(), 'pkgconfig') |