diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-02 14:43:12 -0700 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2022-09-22 18:17:43 -0400 |
| commit | f5283dd63fc40211a935330973a69aa8105aa920 (patch) | |
| tree | c3ea862cb3d08ffcbe8ddaea9d70a42d6ee445de /mesonbuild/wrap | |
| parent | 3ef332e89a7050d0c03801099a0649e00c187278 (diff) | |
| download | meson-f5283dd63fc40211a935330973a69aa8105aa920.zip meson-f5283dd63fc40211a935330973a69aa8105aa920.tar.gz meson-f5283dd63fc40211a935330973a69aa8105aa920.tar.bz2 | |
pylint: enable global-statement
This does force a number of uses of `# pylint: disable` comments, but it
also finds a couple of useless global uses and one place (in the
previous commit) that an easy refactor removes the use of global. Global
is a code smell, so forcing adding a comment to disable helps force
developers to really consider if what they're doing is a good idea.
Diffstat (limited to 'mesonbuild/wrap')
| -rw-r--r-- | mesonbuild/wrap/wrap.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/wrap/wrap.py b/mesonbuild/wrap/wrap.py index 25e96e6..3e2449f 100644 --- a/mesonbuild/wrap/wrap.py +++ b/mesonbuild/wrap/wrap.py @@ -93,7 +93,7 @@ def open_wrapdburl(urlstring: str, allow_insecure: bool = False, have_opt: bool raise WrapException(f'SSL module not available in {sys.executable}: Cannot contact the WrapDB.{insecure_msg}') else: # following code is only for those without Python SSL - global SSL_WARNING_PRINTED + global SSL_WARNING_PRINTED # pylint: disable=global-statement if not SSL_WARNING_PRINTED: mlog.warning(f'SSL module not available in {sys.executable}: WrapDB traffic not authenticated.') SSL_WARNING_PRINTED = True |