diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2022-03-16 15:12:30 +0100 |
---|---|---|
committer | Dylan Baker <dylan@pnwbakers.com> | 2022-03-16 09:24:57 -0700 |
commit | ff844f3a1fd0cac31e2f61add59393b16548c97c (patch) | |
tree | 8c6f1582eb6afd57ecc94e35d16f7e88c4ddada1 /mesonbuild/compilers | |
parent | ca7b16f93717700d9957ba9be0d968c00e2c6b6a (diff) | |
download | meson-ff844f3a1fd0cac31e2f61add59393b16548c97c.zip meson-ff844f3a1fd0cac31e2f61add59393b16548c97c.tar.gz meson-ff844f3a1fd0cac31e2f61add59393b16548c97c.tar.bz2 |
fix detection of language standard library paths
The code in the C++ and Fortran compilers' language_stdlib_only_link_flags
method is broken and cannot possibly have ever worked. Instead of
splitting by line, it splits by whitespace and therefore, instead of
the last line of the compiler output:
programs: =/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
libraries: =/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0
it is only the last field that has its first 11 characters removed.
Instead of reinventing the wheel with a new and brittle pattern,
reuse get_compiler_dirs.
Fixes: 64c267c49 ("compilers: Add default search path stdlib_only_link_flags", 2021-09-25)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'mesonbuild/compilers')
-rw-r--r-- | mesonbuild/compilers/cpp.py | 18 | ||||
-rw-r--r-- | mesonbuild/compilers/fortran.py | 12 |
2 files changed, 10 insertions, 20 deletions
diff --git a/mesonbuild/compilers/cpp.py b/mesonbuild/compilers/cpp.py index 8baa727..e6410c8 100644 --- a/mesonbuild/compilers/cpp.py +++ b/mesonbuild/compilers/cpp.py @@ -251,11 +251,9 @@ class ClangCPPCompiler(ClangCompiler, CPPCompiler): # be passed to a different compiler with a different set of default # search paths, such as when using Clang for C/C++ and gfortran for # fortran, - search_dir = self._get_search_dirs(env) search_dirs: T.List[str] = [] - if search_dir is not None: - for d in search_dir.split()[-1][len('libraries: ='):].split(':'): - search_dirs.append(f'-L{d}') + for d in self.get_compiler_dirs(env, 'libraries'): + search_dirs.append(f'-L{d}') return search_dirs + ['-lstdc++'] @@ -270,11 +268,9 @@ class AppleClangCPPCompiler(ClangCPPCompiler): # be passed to a different compiler with a different set of default # search paths, such as when using Clang for C/C++ and gfortran for # fortran, - search_dir = self._get_search_dirs(env) search_dirs: T.List[str] = [] - if search_dir is not None: - for d in search_dir.split()[-1][len('libraries: ='):].split(':'): - search_dirs.append(f'-L{d}') + for d in self.get_compiler_dirs(env, 'libraries'): + search_dirs.append(f'-L{d}') return search_dirs + ['-lc++'] @@ -430,11 +426,9 @@ class GnuCPPCompiler(GnuCompiler, CPPCompiler): # be passed to a different compiler with a different set of default # search paths, such as when using Clang for C/C++ and gfortran for # fortran, - search_dir = self._get_search_dirs(env) search_dirs: T.List[str] = [] - if search_dir is not None: - for d in search_dir.split()[-1][len('libraries: ='):].split(':'): - search_dirs.append(f'-L{d}') + for d in self.get_compiler_dirs(env, 'libraries'): + search_dirs.append(f'-L{d}') return ['-lstdc++'] diff --git a/mesonbuild/compilers/fortran.py b/mesonbuild/compilers/fortran.py index ba2454d..a5d4b6a 100644 --- a/mesonbuild/compilers/fortran.py +++ b/mesonbuild/compilers/fortran.py @@ -215,11 +215,9 @@ class GnuFortranCompiler(GnuCompiler, FortranCompiler): # be passed to a different compiler with a different set of default # search paths, such as when using Clang for C/C++ and gfortran for # fortran, - search_dir = self._get_search_dirs(env) search_dirs: T.List[str] = [] - if search_dir is not None: - for d in search_dir.split()[-1][len('libraries: ='):].split(':'): - search_dirs.append(f'-L{d}') + for d in self.get_compiler_dirs(env, 'libraries'): + search_dirs.append(f'-L{d}') return search_dirs + ['-lgfortran', '-lm'] def has_header(self, hname: str, prefix: str, env: 'Environment', *, @@ -482,11 +480,9 @@ class FlangFortranCompiler(ClangCompiler, FortranCompiler): # search paths, such as when using Clang for C/C++ and gfortran for # fortran, # XXX: Untested.... - search_dir = self._get_search_dirs(env) search_dirs: T.List[str] = [] - if search_dir is not None: - for d in search_dir.split()[-1][len('libraries: ='):].split(':'): - search_dirs.append(f'-L{d}') + for d in self.get_compiler_dirs(env, 'libraries'): + search_dirs.append(f'-L{d}') return search_dirs + ['-lflang', '-lpgmath'] class ArmLtdFlangFortranCompiler(FlangFortranCompiler): |