aboutsummaryrefslogtreecommitdiff
path: root/ci/ciimage
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2023-05-29 12:03:36 -0400
committerXavier Claessens <xclaesse@gmail.com>2023-05-29 15:04:34 -0400
commit95b03f793028968a4a6df7fe25358fd8c5d39a0c (patch)
treec21e0316e003c86736f43353ade8ef2470272002 /ci/ciimage
parent29ad6dd90c07d4cd762f3eeaf9f61324f7311baf (diff)
downloadmeson-95b03f793028968a4a6df7fe25358fd8c5d39a0c.zip
meson-95b03f793028968a4a6df7fe25358fd8c5d39a0c.tar.gz
meson-95b03f793028968a4a6df7fe25358fd8c5d39a0c.tar.bz2
avoid clearing the dependency cache unnecessarily based on wrap-mode
We actually do not and should not care about wrap-mode at all for this. We want to cache dependency lookups whenever humanly possible, but only use them in cases where we would anyways be using them -- which in particular means if we said to force a subproject fallback for this dep, we want to bypass the cache. Currently, we handle this by always looking up the cache for all dependencies, but clearing the cache at startup if a reconfigure means we are changing our resolution strategy. This is bad -- we might have many dependencies that are worth caching, and only one dependency that should stop being cached and use a subproject instead. The simple solution is to handle the forcefallback case when doing a cache lookup, and not do a cache lookup at all. Now we don't have to nuke the entire cache. In fact, if a future reconfigure changes the forcefallback state back to not being forced, we can reuse the original cached dependency, which is still there. Closes #11828
Diffstat (limited to 'ci/ciimage')
0 files changed, 0 insertions, 0 deletions