diff options
author | Markus Armbruster <armbru@redhat.com> | 2025-07-25 15:50:31 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2025-09-01 13:43:43 +0200 |
commit | a60e1544b515e5205489141fc76cdf26de3a5f1b (patch) | |
tree | eba4e0152b3f8d295e9227b3e357f35e49f5fa58 /tests/qtest | |
parent | 91589bcd9fee0e66b241d04e5f37cd4f218187a2 (diff) | |
download | qemu-a60e1544b515e5205489141fc76cdf26de3a5f1b.zip qemu-a60e1544b515e5205489141fc76cdf26de3a5f1b.tar.gz qemu-a60e1544b515e5205489141fc76cdf26de3a5f1b.tar.bz2 |
qtest/qom-test: Shallow testing of qom-list / qom-get
This test traverses the QOM sub-tree rooted at /machine with a
combination of qom-list and qom-get. In my x86_64 testing, it runs
almost 12000 QMP commands in 34 seconds. With -m slow, we test more
machines, and it takes almost 84000 commands in almost four minutes.
Since commit 3dd93992ffb (tests/qtest/qom-test: unit test for
qom-list-get), the test traverses this tree a second time, with
qom-list-get. In my x86_64 testing, this takes some 200 QMP commands
and around two seconds, and some 1100 in just under 12s with -m slow.
Traversing the entire tree is useful, because it exercise the QOM
property getters. Traversing it twice not so much.
Make the qom-list / qom-get test shallow unless -m slow is given:
don't recurse. Cuts the number of commands to around 600, and run
time to under 5s for me.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250725135034.2280477-3-armbru@redhat.com>
Reviewed-by: Steve Sistare <steven.sistare@oracle.com>
Diffstat (limited to 'tests/qtest')
-rw-r--r-- | tests/qtest/qom-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 4ade1c7..7dea0d8 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -180,7 +180,7 @@ static void test_properties(QTestState *qts, const char *path, bool recurse) links = g_slist_delete_link(links, links); } while (children) { - test_properties(qts, children->data, true); + test_properties(qts, children->data, g_test_slow()); g_free(children->data); children = g_slist_delete_link(children, children); } |