diff options
author | Greg Kurz <groug@kaod.org> | 2020-12-18 11:33:58 +0100 |
---|---|---|
committer | David Gibson <david@gibson.dropbear.id.au> | 2021-01-06 11:09:59 +1100 |
commit | 1105504100c0768d15d862acca8561e1d8d66211 (patch) | |
tree | dce11a07fe3a46b321e1659ddb6760e8a45fcff3 /scripts/qemu-gdb.py | |
parent | babb819f945a0f279e021e3fc09283080bace61d (diff) | |
download | qemu-1105504100c0768d15d862acca8561e1d8d66211.zip qemu-1105504100c0768d15d862acca8561e1d8d66211.tar.gz qemu-1105504100c0768d15d862acca8561e1d8d66211.tar.bz2 |
spapr: Use spapr_drc_reset_all() at machine reset
Documentation of object_child_foreach_recursive() clearly stipulates
that "it is forbidden to add or remove children from @obj from the @fn
callback". But this is exactly what we do during machine reset. The call
to spapr_drc_reset() can finalize the hot-unplug sequence of a PHB or a
PCI bridge, both of which will then in turn destroy their PCI DRCs. This
could potentially invalidate the iterator used by do_object_child_foreach().
It is pure luck that this haven't caused any issues so far.
Use spapr_drc_reset_all() since it can cope with DRC removal.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20201218103400.689660-5-groug@kaod.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'scripts/qemu-gdb.py')
0 files changed, 0 insertions, 0 deletions