aboutsummaryrefslogtreecommitdiff
path: root/scripts/qapi
diff options
context:
space:
mode:
authorJoonas Kankaala <joonas.a.kankaala@gmail.com>2024-03-09 19:29:32 +0200
committerMichael Tokarev <mjt@tls.msk.ru>2024-04-01 19:47:40 +0300
commit8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d (patch)
treed77013f09af80fa911e94d1b916ef1eec75dceac /scripts/qapi
parent6af9d12c88b9720f209912f6e4b01fefe5906d59 (diff)
downloadqemu-8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d.zip
qemu-8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d.tar.gz
qemu-8e0cd23f7163f7f203bdaffd9f06feaa49dcec2d.tar.bz2
usb-audio: Fix invalid values in AudioControl descriptors
This fixes the invalid bInterfaceProtocol value 0x04 in the USB audio AudioControl descriptors. It should be zero. While Linux and Windows forgive this error, macOS 14 Sonoma does not. The usb-audio device does not appear in macOS sound settings even though the device is recognized and shows up in USB system information. According to the USB audio class specs 1.0-4.0, valid values are 0x00, 0x20, 0x30 and 0x40. (Note also that Linux prints the warning "unknown interface protocol 0x4, assuming v1", but then proceeds as if the value was zero.) This also fixes the invalid wTotalLength value in the multi-channel setup AudioControl interface header descriptor (used when multi=on and out.mixing-engine off). The combined length of all the descriptors there add up to 0x37, not 0x38. In Linux, "lsusb -D ..." displays incomplete descriptor information when this length is incorrect. Signed-off-by: Joonas Kankaala <joonas.a.kankaala@gmail.com> Reviewed-by: Volker RĂ¼melin <vr_qemu@t-online.de> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'scripts/qapi')
0 files changed, 0 insertions, 0 deletions