aboutsummaryrefslogtreecommitdiff
path: root/scripts/qapi/commands.py
diff options
context:
space:
mode:
authorPeter Krempa <pkrempa@redhat.com>2025-01-27 11:29:24 +0100
committerKevin Wolf <kwolf@redhat.com>2025-02-06 13:59:01 +0100
commit107c551de0d7bc3aa8e926c557b66b9549616f42 (patch)
treeb68435330b3de0e55f70f787ba9837798955c015 /scripts/qapi/commands.py
parent772f86839f777148089e0b248a78986406ee3660 (diff)
downloadqemu-107c551de0d7bc3aa8e926c557b66b9549616f42.zip
qemu-107c551de0d7bc3aa8e926c557b66b9549616f42.tar.gz
qemu-107c551de0d7bc3aa8e926c557b66b9549616f42.tar.bz2
block-backend: Fix argument order when calling 'qapi_event_send_block_io_error()'
Commit 7452162adec25c10 introduced 'qom-path' argument to BLOCK_IO_ERROR event but when the event is instantiated in 'send_qmp_error_event()' the arguments for 'device' and 'qom_path' in qapi_event_send_block_io_error() were reversed : Generated code for sending event: void qapi_event_send_block_io_error(const char *qom_path, const char *device, const char *node_name, IoOperationType operation, [...] Call inside send_qmp_error_event(): qapi_event_send_block_io_error(blk_name(blk), blk_get_attached_dev_path(blk), bs ? bdrv_get_node_name(bs) : NULL, optype, [...] This results into reporting the QOM path as the device alias and vice versa which in turn breaks libvirt, which expects the device alias being either a valid alias or empty (which would make libvirt do the lookup by node-name instead). Cc: qemu-stable@nongnu.org Fixes: 7452162adec2 ("qapi: add qom-path to BLOCK_IO_ERROR event") Signed-off-by: Peter Krempa <pkrempa@redhat.com> Message-ID: <09728d784888b38d7a8f09ee5e9e9c542c875e1e.1737973614.git.pkrempa@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/qapi/commands.py')
0 files changed, 0 insertions, 0 deletions