diff options
| author | Cédric Le Goater <clg@redhat.com> | 2024-05-22 19:01:04 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2024-06-24 08:03:33 +0200 |
| commit | 45f4218784ce20b2c303dd07b1fa3aa6838eca73 (patch) | |
| tree | 6e296d0dc31f2a9808626078956f0cdd800bad6f /hw/vfio/ccw.c | |
| parent | 19a1740fd3eb31ffc5b73ed101f1e3847c546631 (diff) | |
| download | qemu-45f4218784ce20b2c303dd07b1fa3aa6838eca73.zip qemu-45f4218784ce20b2c303dd07b1fa3aa6838eca73.tar.gz qemu-45f4218784ce20b2c303dd07b1fa3aa6838eca73.tar.bz2 | |
s390x/css: Make S390CCWDeviceClass::realize return bool
Since the realize() handler of S390CCWDeviceClass takes an 'Error **'
argument, best practices suggest to return a bool. See the api/error.h
Rules section. While at it, modify the call in vfio_ccw_realize().
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240522170107.289532-5-clg@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'hw/vfio/ccw.c')
| -rw-r--r-- | hw/vfio/ccw.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 2600e62..9a8e052 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -582,8 +582,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp) /* Call the class init function for subchannel. */ if (cdc->realize) { - cdc->realize(cdev, vcdev->vdev.sysfsdev, &err); - if (err) { + if (!cdc->realize(cdev, vcdev->vdev.sysfsdev, &err)) { goto out_err_propagate; } } |