diff options
| author | Laurent Vivier <lvivier@redhat.com> | 2024-01-24 11:29:03 +0100 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2024-03-12 19:28:31 +0800 |
| commit | 65c2ab808571dcd9322020690a63df63281a67f0 (patch) | |
| tree | 573a97b3f6ad9b655ba85c04f0e329b87e213f95 /hw/net/virtio-net.c | |
| parent | 05ec974671200814fa5c1d5db710e0e4b88a40af (diff) | |
| download | qemu-65c2ab808571dcd9322020690a63df63281a67f0.zip qemu-65c2ab808571dcd9322020690a63df63281a67f0.tar.gz qemu-65c2ab808571dcd9322020690a63df63281a67f0.tar.bz2 | |
igb: fix link state on resume
On resume igb_vm_state_change() always calls igb_autoneg_resume()
that sets link_down to false, and thus activates the link even
if we have disabled it.
The problem can be reproduced starting qemu in paused state (-S) and
then set the link to down. When we resume the machine the link appears
to be up.
Reproducer:
# qemu-system-x86_64 ... -device igb,netdev=netdev0,id=net0 -S
{"execute": "qmp_capabilities" }
{"execute": "set_link", "arguments": {"name": "net0", "up": false}}
{"execute": "cont" }
To fix the problem, merge the content of igb_vm_state_change()
into igb_core_post_load() as e1000 does.
Buglink: https://issues.redhat.com/browse/RHEL-21867
Fixes: 3a977deebe6b ("Intrdocue igb device emulation")
Cc: akihiko.odaki@daynix.com
Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/net/virtio-net.c')
0 files changed, 0 insertions, 0 deletions