aboutsummaryrefslogtreecommitdiff
path: root/backends
diff options
context:
space:
mode:
authorCédric Le Goater <clg@redhat.com>2025-02-06 14:14:34 +0100
committerCédric Le Goater <clg@redhat.com>2025-02-11 14:15:19 +0100
commit889695f8f3c10647cc27a3788b4a3f1d0192926c (patch)
treeaf6c7c9a3e03b9a30e0a6d2e138a70d26f7eef41 /backends
parentaaec00422ba6538ca3e6bfa612bbae155ec15c84 (diff)
downloadqemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.zip
qemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.tar.gz
qemu-889695f8f3c10647cc27a3788b4a3f1d0192926c.tar.bz2
vfio: Remove reports of DMA mapping errors in backends
Currently, the mapping handlers of the IOMMU backends, VFIO IOMMU Type 1 aka. legacy and IOMMUFD, return an errno and also report an error. This can lead to excessive log messages at runtime for recurring DMA mapping errors. Since these errors are already reported by the callers in the vfio_container_dma_un/map() routines, simply remove them and allow the callers to handle the reporting. The mapping handler of the IOMMUFD backend has a comment suggesting MMIO region mapping failures return EFAULT. I am not sure this is entirely true, so keep the EFAULT case until the conditions are clarified. Reviewed-by: Alex Williamson <alex.williamson@redhat.com> Link: https://lore.kernel.org/qemu-devel/20250206131438.1505542-7-clg@redhat.com Signed-off-by: Cédric Le Goater <clg@redhat.com>
Diffstat (limited to 'backends')
-rw-r--r--backends/iommufd.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/backends/iommufd.c b/backends/iommufd.c
index 7b4fc8e..d57da44 100644
--- a/backends/iommufd.c
+++ b/backends/iommufd.c
@@ -167,8 +167,6 @@ int iommufd_backend_map_dma(IOMMUFDBackend *be, uint32_t ioas_id, hwaddr iova,
/* TODO: Not support mapping hardware PCI BAR region for now. */
if (errno == EFAULT) {
warn_report("IOMMU_IOAS_MAP failed: %m, PCI BAR?");
- } else {
- error_report("IOMMU_IOAS_MAP failed: %m");
}
}
return ret;
@@ -203,7 +201,6 @@ int iommufd_backend_unmap_dma(IOMMUFDBackend *be, uint32_t ioas_id,
if (ret) {
ret = -errno;
- error_report("IOMMU_IOAS_UNMAP failed: %m");
}
return ret;
}