diff options
| author | Zhenzhong Duan <zhenzhong.duan@intel.com> | 2025-06-27 14:33:31 +0800 |
|---|---|---|
| committer | Cédric Le Goater <clg@redhat.com> | 2025-07-03 13:42:28 +0200 |
| commit | e8c1128bf982f2e5f7c9ca6c1de632feec3d9e94 (patch) | |
| tree | 4aab7fb8330031fc78a0608ea268e43c5be94efb | |
| parent | c77283dd5d79149f4e7e9edd00f65416c648ee59 (diff) | |
| download | qemu-e8c1128bf982f2e5f7c9ca6c1de632feec3d9e94.zip qemu-e8c1128bf982f2e5f7c9ca6c1de632feec3d9e94.tar.gz qemu-e8c1128bf982f2e5f7c9ca6c1de632feec3d9e94.tar.bz2 | |
vfio/container: Fix potential SIGSEGV when recover from unmap-all-vaddr failure
CPR overrides then restores dma_map in both outgoing and incoming QEMU, for
different reasons. But it only sets saved_dma_map in the target.
Fix it by always setting saved_dma_map.
Fixes: eba1f657cbb1 ("vfio/container: recover from unmap-all-vaddr failure")
Suggested-by: Steven Sistare <steven.sistare@oracle.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Steve Sistare <steven.sistare@oracle.com>
Link: https://lore.kernel.org/qemu-devel/20250627063332.5173-2-zhenzhong.duan@intel.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
| -rw-r--r-- | hw/vfio/cpr-legacy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/vfio/cpr-legacy.c b/hw/vfio/cpr-legacy.c index a84c324..0a5d1bd 100644 --- a/hw/vfio/cpr-legacy.c +++ b/hw/vfio/cpr-legacy.c @@ -180,9 +180,9 @@ bool vfio_legacy_cpr_register_container(VFIOContainer *container, Error **errp) vmstate_register(NULL, -1, &vfio_container_vmstate, container); /* During incoming CPR, divert calls to dma_map. */ + VFIOIOMMUClass *vioc = VFIO_IOMMU_GET_CLASS(bcontainer); + container->cpr.saved_dma_map = vioc->dma_map; if (cpr_is_incoming()) { - VFIOIOMMUClass *vioc = VFIO_IOMMU_GET_CLASS(bcontainer); - container->cpr.saved_dma_map = vioc->dma_map; vioc->dma_map = vfio_legacy_cpr_dma_map; } |