diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-01-26 14:34:19 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-03-06 15:46:18 +0100 |
| commit | ae24e13a9f46128fb815957dc234020351797c0e (patch) | |
| tree | f98c42c93c34e3f334ff764e07e084f6f298c27a | |
| parent | 059eb605fd67f15c0ca7f07c7a02c319035b095b (diff) | |
| download | qemu-ae24e13a9f46128fb815957dc234020351797c0e.zip qemu-ae24e13a9f46128fb815957dc234020351797c0e.tar.gz qemu-ae24e13a9f46128fb815957dc234020351797c0e.tar.bz2 | |
disas: Remove target_words_bigendian() call in initialize_debug_target()
All CPUClass implementating disas_set_info() must set the
disassemble_info::endian value.
Ensure that by setting %endian to BFD_ENDIAN_UNKNOWN before
calling the CPUClass::disas_set_info() handler, then asserting
%endian is not BFD_ENDIAN_UNKNOWN after the call.
This allows removing the target_words_bigendian() call in disas/.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20250210212931.62401-11-philmd@linaro.org>
| -rw-r--r-- | disas/disas-common.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/disas/disas-common.c b/disas/disas-common.c index de61f6d..ae3f9e4 100644 --- a/disas/disas-common.c +++ b/disas/disas-common.c @@ -7,7 +7,6 @@ #include "disas/disas.h" #include "disas/capstone.h" #include "hw/core/cpu.h" -#include "exec/tswap.h" #include "disas-internal.h" @@ -61,15 +60,12 @@ void disas_initialize_debug_target(CPUDebug *s, CPUState *cpu) s->cpu = cpu; s->info.print_address_func = print_address; - if (target_words_bigendian()) { - s->info.endian = BFD_ENDIAN_BIG; - } else { - s->info.endian = BFD_ENDIAN_LITTLE; - } + s->info.endian = BFD_ENDIAN_UNKNOWN; CPUClass *cc = CPU_GET_CLASS(cpu); if (cc->disas_set_info) { cc->disas_set_info(cpu, &s->info); + g_assert(s->info.endian != BFD_ENDIAN_UNKNOWN); } } |