diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2025-06-10 13:36:52 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2025-06-12 13:40:15 -0400 |
| commit | 8b1dac1ad57082611419b0e2f347acd96115d25f (patch) | |
| tree | e9070d30da4674c3dd520eab1122c979e548556c | |
| parent | bb71d9fe1419f44529c91d1b09464718d157e647 (diff) | |
| download | qemu-8b1dac1ad57082611419b0e2f347acd96115d25f.zip qemu-8b1dac1ad57082611419b0e2f347acd96115d25f.tar.gz qemu-8b1dac1ad57082611419b0e2f347acd96115d25f.tar.bz2 | |
hw/char/sclpconsole-lm: skip automatic zero-init of large array
The 'process_mdb' method has a 4k byte array used for copying data
between the guest and the chardev backend. Skip the automatic zero-init
of this array to eliminate the performance overhead in the I/O hot
path.
The 'buffer' array will be selectively initialized when data is converted
between EBCDIC and ASCII.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20250610123709.835102-15-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | hw/char/sclpconsole-lm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c index e9580aa..3e40d5e 100644 --- a/hw/char/sclpconsole-lm.c +++ b/hw/char/sclpconsole-lm.c @@ -214,7 +214,7 @@ static int process_mdb(SCLPEvent *event, MDBO *mdbo) { int rc; int len; - uint8_t buffer[SIZE_BUFFER]; + QEMU_UNINITIALIZED uint8_t buffer[SIZE_BUFFER]; len = be16_to_cpu(mdbo->length); len -= sizeof(mdbo->length) + sizeof(mdbo->type) |