aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2025-06-10 13:36:56 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2025-06-12 13:40:15 -0400
commit6992c886838282f36b20deee44b666bbfc573a8f (patch)
tree856f7922c76a99d882903eb6326eb3cec59993b3
parent5a1f614d0cd0bcc8e84e0b7ab6af63d56bd348a2 (diff)
downloadqemu-6992c886838282f36b20deee44b666bbfc573a8f.zip
qemu-6992c886838282f36b20deee44b666bbfc573a8f.tar.gz
qemu-6992c886838282f36b20deee44b666bbfc573a8f.tar.bz2
hw/misc/aspeed_hace: skip automatic zero-init of large array
The 'do_hash_operation' method has a 256 element iovec array used for holding pointers to data that is to be hashed. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'iovec' array will be selectively initialized based on data that needs to be hashed. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-id: 20250610123709.835102-19-berrange@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--hw/misc/aspeed_hace.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c
index 8924a30..726368f 100644
--- a/hw/misc/aspeed_hace.c
+++ b/hw/misc/aspeed_hace.c
@@ -419,7 +419,7 @@ static void hash_execute_acc_mode(AspeedHACEState *s, int algo,
static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode,
bool acc_mode)
{
- struct iovec iov[ASPEED_HACE_MAX_SG];
+ QEMU_UNINITIALIZED struct iovec iov[ASPEED_HACE_MAX_SG];
bool acc_final_request = false;
int iov_idx = -1;