aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2025-08-12 14:59:32 -0400
committerStefan Hajnoczi <stefanha@redhat.com>2025-08-12 14:59:33 -0400
commit30f830fa887ad3756419a7e92b3d22b29a7ac43f (patch)
tree1777cd9bdce29e82ebea9caf47d5cbc902f28d54
parent6ad034e71232c2929ed546304c9d249312bb632f (diff)
parent7db162fa013878b06a528686ece79ad99f699c71 (diff)
downloadqemu-30f830fa887ad3756419a7e92b3d22b29a7ac43f.zip
qemu-30f830fa887ad3756419a7e92b3d22b29a7ac43f.tar.gz
qemu-30f830fa887ad3756419a7e92b3d22b29a7ac43f.tar.bz2
Merge tag 'sdmmc-20250812' of https://github.com/philmd/qemu into staging
SD/MMC patches queue - Return noise (dummy byte) when no SD card connected over SPI # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmibcbsACgkQ4+MsLN6t # wN5DkA/9F9lOPelfONSvAkZ4IkahoTaulYglQHxePbYvCopufx7RiM5yigmVrcGW # I6MhGf9PtD4nlQ6Zl8ZUcr+WHMZQJaCcizdtzDsWR597to1z+ylbgoQqlhZi3gEX # V6mOl5peS2LZ0nZ5WQpMs9kNUTTGahTagqkBRLWTCuTVZF/UAyXGFGK+9U3c4vu+ # iOS8XMkfACg2Df51Jj4cnyMmjjYoJgoQliGueaiOTyNEL0Euq18t/FiaL1C6X9+i # rraagCq9s4rVLeh3KTZSz4ywKHticNtsXpHXGzlBIRJbxGCv7rV4GOehzjHdDcgq # H7zpv9l7J4bBr9uY6m8SHP0WkxKE/B+g261h6mIg3PNjyamjrwWnoX9IYU4wPaVu # +JUaxqU24HUyVi5r//h5pCASQPCl0MhtrsDHQSvClaiXVcCu8dBfiFxR5+tDuCaO # An6ORL+Rd5S5dS36XQZr+CnmLCfnlr10auPq4tQ+L32VcPWjqHp+70+yM4DVtPfq # sFb1O5ChQEsCzk9laO7OLqDqf8zJ5T4n21/i83vH/QGOi4+NRFIJoncGfXmHW/GW # OzAE1S3LRDVBq+RA66so4y30i83H2CCZNqjRkXCoa+680P0MP5aUSxNhS7T3dN6u # Er3QXkZQPeQDtVTCbslXnEtJ7drU6Jtfj4ZPTanua9TpCotAnb4= # =4VWG # -----END PGP SIGNATURE----- # gpg: Signature made Tue 12 Aug 2025 12:54:19 EDT # gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE # gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" [full] # Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE * tag 'sdmmc-20250812' of https://github.com/philmd/qemu: tests/functional: Test SPI-SD adapter without SD card connected hw/sd/ssi-sd: Return noise (dummy byte) when no card connected Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--hw/sd/ssi-sd.c4
-rwxr-xr-xtests/functional/test_riscv64_sifive_u.py22
2 files changed, 21 insertions, 5 deletions
diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c
index 594dead..3aacbd0 100644
--- a/hw/sd/ssi-sd.c
+++ b/hw/sd/ssi-sd.c
@@ -89,6 +89,10 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val)
SDRequest request;
uint8_t longresp[5];
+ if (!sdbus_get_inserted(&s->sdbus)) {
+ return SSI_DUMMY;
+ }
+
/*
* Special case: allow CMD12 (STOP TRANSMISSION) while reading data.
*
diff --git a/tests/functional/test_riscv64_sifive_u.py b/tests/functional/test_riscv64_sifive_u.py
index dc4cb8a..358ff0d 100755
--- a/tests/functional/test_riscv64_sifive_u.py
+++ b/tests/functional/test_riscv64_sifive_u.py
@@ -27,25 +27,37 @@ class SifiveU(LinuxKernelTest):
'rootfs.ext2.gz'),
'b6ed95610310b7956f9bf20c4c9c0c05fea647900df441da9dfe767d24e8b28b')
- def test_riscv64_sifive_u_mmc_spi(self):
+ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card):
self.set_machine('sifive_u')
kernel_path = self.ASSET_KERNEL.fetch()
rootfs_path = self.uncompress(self.ASSET_ROOTFS)
self.vm.set_console()
kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
- 'root=/dev/mmcblk0 rootwait '
'earlycon=sbi console=ttySIF0 '
- 'panic=-1 noreboot')
+ 'root=/dev/mmcblk0 ')
self.vm.add_args('-kernel', kernel_path,
- '-drive', f'file={rootfs_path},if=sd,format=raw',
'-append', kernel_command_line,
'-no-reboot')
+ if connect_card:
+ kernel_command_line += 'panic=-1 noreboot rootwait '
+ self.vm.add_args('-drive', f'file={rootfs_path},if=sd,format=raw')
+ pattern = 'Boot successful.'
+ else:
+ kernel_command_line += 'panic=0 noreboot '
+ pattern = 'Cannot open root device "mmcblk0" or unknown-block(0,0)'
+
self.vm.launch()
- self.wait_for_console_pattern('Boot successful.')
+ self.wait_for_console_pattern(pattern)
os.remove(rootfs_path)
+ def test_riscv64_sifive_u_nommc_spi(self):
+ self.do_test_riscv64_sifive_u_mmc_spi(False)
+
+ def test_riscv64_sifive_u_mmc_spi(self):
+ self.do_test_riscv64_sifive_u_mmc_spi(True)
+
if __name__ == '__main__':
LinuxKernelTest.main()