1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
|
//===-- MainLoopTest.cpp --------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/Host/MainLoop.h"
#include "TestingSupport/SubsystemRAII.h"
#include "lldb/Host/ConnectionFileDescriptor.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Host/MainLoopBase.h"
#include "lldb/Host/PseudoTerminal.h"
#include "lldb/Host/common/TCPSocket.h"
#include "llvm/Config/llvm-config.h" // for LLVM_ON_UNIX
#include "llvm/Testing/Support/Error.h"
#include "gtest/gtest.h"
#include <chrono>
#include <future>
#include <thread>
using namespace lldb_private;
namespace {
class MainLoopTest : public testing::Test {
public:
SubsystemRAII<FileSystem, Socket> subsystems;
void SetUp() override {
Status error;
auto listen_socket_up = std::make_unique<TCPSocket>(true);
ASSERT_TRUE(error.Success());
error = listen_socket_up->Listen("localhost:0", 5);
ASSERT_TRUE(error.Success());
Socket *accept_socket;
auto connect_socket_up = std::make_unique<TCPSocket>(true);
error = connect_socket_up->Connect(
llvm::formatv("localhost:{0}", listen_socket_up->GetLocalPortNumber())
.str());
ASSERT_TRUE(error.Success());
ASSERT_TRUE(listen_socket_up->Accept(std::chrono::seconds(1), accept_socket)
.Success());
callback_count = 0;
socketpair[0] = std::move(connect_socket_up);
socketpair[1].reset(accept_socket);
}
void TearDown() override {
socketpair[0].reset();
socketpair[1].reset();
}
protected:
MainLoop::Callback make_callback() {
return [&](MainLoopBase &loop) {
++callback_count;
loop.RequestTermination();
};
}
std::shared_ptr<Socket> socketpair[2];
unsigned callback_count;
};
} // namespace
TEST_F(MainLoopTest, ReadSocketObject) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_TRUE(socketpair[0]->Write(&X, len).Success());
MainLoop loop;
Status error;
auto handle = loop.RegisterReadObject(socketpair[1], make_callback(), error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, ReadPipeObject) {
Pipe pipe;
ASSERT_TRUE(pipe.CreateNew().Success());
MainLoop loop;
char X = 'X';
size_t len = sizeof(X);
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
Status error;
auto handle = loop.RegisterReadObject(
std::make_shared<NativeFile>(pipe.GetReadFileDescriptor(),
File::eOpenOptionReadOnly, false),
make_callback(), error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, MultipleReadsPipeObject) {
Pipe pipe;
ASSERT_TRUE(pipe.CreateNew().Success());
MainLoop loop;
std::future<void> async_writer = std::async(std::launch::async, [&] {
for (int i = 0; i < 5; ++i) {
std::this_thread::sleep_for(std::chrono::milliseconds(500));
char X = 'X';
size_t len = sizeof(X);
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
}
});
Status error;
lldb::FileSP file = std::make_shared<NativeFile>(
pipe.GetReadFileDescriptor(), File::eOpenOptionReadOnly, false);
auto handle = loop.RegisterReadObject(
file,
[&](MainLoopBase &loop) {
callback_count++;
if (callback_count == 5)
loop.RequestTermination();
// Read some data to ensure the handle is not in a readable state.
char buf[1024] = {0};
size_t len = sizeof(buf);
ASSERT_THAT_ERROR(file->Read(buf, len).ToError(), llvm::Succeeded());
EXPECT_EQ(len, 1U);
EXPECT_EQ(buf[0], 'X');
},
error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(5u, callback_count);
async_writer.wait();
}
TEST_F(MainLoopTest, PipeDelayBetweenRegisterAndRun) {
Pipe pipe;
ASSERT_TRUE(pipe.CreateNew().Success());
MainLoop loop;
Status error;
lldb::FileSP file = std::make_shared<NativeFile>(
pipe.GetReadFileDescriptor(), File::eOpenOptionReadOnly, false);
auto handle = loop.RegisterReadObject(
file,
[&](MainLoopBase &loop) {
callback_count++;
// Read some data to ensure the handle is not in a readable state.
char buf[1024] = {0};
size_t len = sizeof(buf);
ASSERT_THAT_ERROR(file->Read(buf, len).ToError(), llvm::Succeeded());
EXPECT_EQ(len, 2U);
EXPECT_EQ(buf[0], 'X');
EXPECT_EQ(buf[1], 'X');
},
error);
auto cb = [&](MainLoopBase &) {
callback_count++;
char X = 'X';
size_t len = sizeof(X);
// Write twice and ensure we coalesce into a single read.
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
};
// Add a write that triggers a read events.
loop.AddCallback(cb, std::chrono::milliseconds(500));
loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
std::chrono::milliseconds(1000));
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
// Write between RegisterReadObject / Run should NOT invoke the callback.
cb(loop);
ASSERT_EQ(1u, callback_count);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(4u, callback_count);
}
TEST_F(MainLoopTest, NoSelfTriggersDuringPipeHandler) {
Pipe pipe;
ASSERT_TRUE(pipe.CreateNew().Success());
MainLoop loop;
Status error;
lldb::FileSP file = std::make_shared<NativeFile>(
pipe.GetReadFileDescriptor(), File::eOpenOptionReadOnly, false);
auto handle = loop.RegisterReadObject(
file,
[&](MainLoopBase &lop) {
callback_count++;
char X = 'Y';
size_t len = sizeof(X);
// writes / reads during the handler callback should NOT trigger itself.
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
char buf[1024] = {0};
len = sizeof(buf);
ASSERT_THAT_ERROR(file->Read(buf, len).ToError(), llvm::Succeeded());
EXPECT_EQ(len, 2U);
EXPECT_EQ(buf[0], 'X');
EXPECT_EQ(buf[1], 'Y');
if (callback_count == 2)
loop.RequestTermination();
},
error);
// Add a write that triggers a read event.
loop.AddPendingCallback([&](MainLoopBase &) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
});
loop.AddCallback(
[&](MainLoopBase &) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::HasValue(1));
},
std::chrono::milliseconds(500));
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(2u, callback_count);
}
TEST_F(MainLoopTest, NoSpuriousPipeReads) {
Pipe pipe;
ASSERT_TRUE(pipe.CreateNew().Success());
char X = 'X';
size_t len = sizeof(X);
ASSERT_THAT_EXPECTED(pipe.Write(&X, len), llvm::Succeeded());
lldb::IOObjectSP r = std::make_shared<NativeFile>(
pipe.GetReadFileDescriptor(), File::eOpenOptionReadOnly, false);
MainLoop loop;
Status error;
auto handle = loop.RegisterReadObject(
r,
[&](MainLoopBase &) {
if (callback_count == 0) {
// Read the byte back the first time we're called. After that, the
// pipe is empty, and we should not be called anymore.
char X;
size_t len = sizeof(X);
ASSERT_THAT_ERROR(r->Read(&X, len).ToError(), llvm::Succeeded());
EXPECT_EQ(len, sizeof(X));
EXPECT_EQ(X, 'X');
}
++callback_count;
},
error);
ASSERT_THAT_ERROR(error.ToError(), llvm::Succeeded());
// Terminate the loop after one second.
loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
std::chrono::seconds(1));
ASSERT_THAT_ERROR(loop.Run().ToError(), llvm::Succeeded());
// Make sure the callback was called only once.
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, NoSpuriousSocketReads) {
// Write one byte into the socket.
char X = 'X';
size_t len = sizeof(X);
ASSERT_TRUE(socketpair[0]->Write(&X, len).Success());
MainLoop loop;
Status error;
auto handle = loop.RegisterReadObject(
socketpair[1],
[this](MainLoopBase &) {
if (callback_count == 0) {
// Read the byte back the first time we're called. After that, the
// socket is empty, and we should not be called anymore.
char X;
size_t len = sizeof(X);
EXPECT_THAT_ERROR(socketpair[1]->Read(&X, len).ToError(),
llvm::Succeeded());
EXPECT_EQ(len, sizeof(X));
EXPECT_EQ(X, 'X');
}
++callback_count;
},
error);
ASSERT_THAT_ERROR(error.ToError(), llvm::Succeeded());
// Terminate the loop after one second.
loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
std::chrono::seconds(1));
ASSERT_THAT_ERROR(loop.Run().ToError(), llvm::Succeeded());
// Make sure the callback was called only once.
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, TerminatesImmediately) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_TRUE(socketpair[0]->Write(&X, len).Success());
ASSERT_TRUE(socketpair[1]->Write(&X, len).Success());
MainLoop loop;
Status error;
auto handle0 = loop.RegisterReadObject(socketpair[0], make_callback(), error);
ASSERT_TRUE(error.Success());
auto handle1 = loop.RegisterReadObject(socketpair[1], make_callback(), error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, PendingCallback) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_TRUE(socketpair[0]->Write(&X, len).Success());
MainLoop loop;
Status error;
auto handle = loop.RegisterReadObject(
socketpair[1],
[&](MainLoopBase &loop) {
// Both callbacks should be called before the loop terminates.
loop.AddPendingCallback(make_callback());
loop.AddPendingCallback(make_callback());
loop.RequestTermination();
},
error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(2u, callback_count);
}
TEST_F(MainLoopTest, PendingCallbackCalledOnlyOnce) {
char X = 'X';
size_t len = sizeof(X);
ASSERT_TRUE(socketpair[0]->Write(&X, len).Success());
MainLoop loop;
Status error;
auto handle = loop.RegisterReadObject(
socketpair[1],
[&](MainLoopBase &loop) {
// Add one pending callback on the first iteration.
if (callback_count == 0) {
loop.AddPendingCallback(
[&](MainLoopBase &loop) { callback_count++; });
}
// Terminate the loop on second iteration.
if (callback_count++ >= 1)
loop.RequestTermination();
},
error);
ASSERT_TRUE(error.Success());
ASSERT_TRUE(handle);
ASSERT_TRUE(loop.Run().Success());
// 2 iterations of read callback + 1 call of pending callback.
ASSERT_EQ(3u, callback_count);
}
TEST_F(MainLoopTest, PendingCallbackTrigger) {
MainLoop loop;
std::promise<void> add_callback2;
bool callback1_called = false;
loop.AddPendingCallback([&](MainLoopBase &loop) {
callback1_called = true;
add_callback2.set_value();
});
Status error;
ASSERT_THAT_ERROR(error.ToError(), llvm::Succeeded());
bool callback2_called = false;
std::thread callback2_adder([&]() {
add_callback2.get_future().get();
loop.AddPendingCallback([&](MainLoopBase &loop) {
callback2_called = true;
loop.RequestTermination();
});
});
ASSERT_THAT_ERROR(loop.Run().ToError(), llvm::Succeeded());
callback2_adder.join();
ASSERT_TRUE(callback1_called);
ASSERT_TRUE(callback2_called);
}
TEST_F(MainLoopTest, ManyPendingCallbacks) {
MainLoop loop;
Status error;
// Try to fill up the pipe buffer and make sure bad things don't happen. This
// is a regression test for the case where writing to the interrupt pipe
// caused a deadlock when the pipe filled up (either because the main loop was
// not running, because it was slow, or because it was busy/blocked doing
// something else).
for (int i = 0; i < 65536; ++i)
loop.AddPendingCallback(
[&](MainLoopBase &loop) { loop.RequestTermination(); });
ASSERT_TRUE(loop.Run().Success());
}
TEST_F(MainLoopTest, CallbackWithTimeout) {
MainLoop loop;
loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
std::chrono::seconds(2));
auto start = std::chrono::steady_clock::now();
ASSERT_THAT_ERROR(loop.Run().takeError(), llvm::Succeeded());
EXPECT_GE(std::chrono::steady_clock::now() - start, std::chrono::seconds(2));
}
TEST_F(MainLoopTest, TimedCallbacksRunInOrder) {
MainLoop loop;
auto start = std::chrono::steady_clock::now();
std::chrono::milliseconds epsilon(10);
std::vector<int> order;
auto add_cb = [&](int id) {
loop.AddCallback([&order, id](MainLoopBase &) { order.push_back(id); },
start + id * epsilon);
};
add_cb(3);
add_cb(2);
add_cb(4);
add_cb(1);
loop.AddCallback([](MainLoopBase &loop) { loop.RequestTermination(); },
start + 5 * epsilon);
ASSERT_THAT_ERROR(loop.Run().takeError(), llvm::Succeeded());
EXPECT_GE(std::chrono::steady_clock::now() - start, 5 * epsilon);
ASSERT_THAT(order, testing::ElementsAre(1, 2, 3, 4));
}
TEST_F(MainLoopTest, TimedCallbackShortensSleep) {
MainLoop loop;
auto start = std::chrono::steady_clock::now();
bool long_callback_called = false;
loop.AddCallback(
[&](MainLoopBase &loop) {
long_callback_called = true;
loop.RequestTermination();
},
std::chrono::seconds(30));
std::future<Status> async_run =
std::async(std::launch::async, &MainLoop::Run, std::ref(loop));
std::this_thread::sleep_for(std::chrono::milliseconds(100));
bool short_callback_called = false;
loop.AddCallback(
[&](MainLoopBase &loop) {
short_callback_called = true;
loop.RequestTermination();
},
std::chrono::seconds(1));
ASSERT_THAT_ERROR(async_run.get().takeError(), llvm::Succeeded());
EXPECT_LT(std::chrono::steady_clock::now() - start, std::chrono::seconds(10));
EXPECT_TRUE(short_callback_called);
EXPECT_FALSE(long_callback_called);
}
#ifdef LLVM_ON_UNIX
TEST_F(MainLoopTest, DetectsEOF) {
PseudoTerminal term;
ASSERT_THAT_ERROR(term.OpenFirstAvailablePrimary(O_RDWR), llvm::Succeeded());
ASSERT_THAT_ERROR(term.OpenSecondary(O_RDWR | O_NOCTTY), llvm::Succeeded());
auto conn = std::make_unique<ConnectionFileDescriptor>(
term.ReleasePrimaryFileDescriptor(), true);
Status error;
MainLoop loop;
auto handle =
loop.RegisterReadObject(conn->GetReadObject(), make_callback(), error);
ASSERT_TRUE(error.Success());
term.CloseSecondaryFileDescriptor();
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, Signal) {
MainLoop loop;
Status error;
auto handle = loop.RegisterSignal(SIGUSR1, make_callback(), error);
ASSERT_TRUE(error.Success());
kill(getpid(), SIGUSR1);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
TEST_F(MainLoopTest, SignalOnOtherThread) {
MainLoop loop;
Status error;
auto handle = loop.RegisterSignal(SIGUSR1, make_callback(), error);
ASSERT_TRUE(error.Success());
std::thread([] { pthread_kill(pthread_self(), SIGUSR1); }).join();
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
// Test that a signal which is not monitored by the MainLoop does not
// cause a premature exit.
TEST_F(MainLoopTest, UnmonitoredSignal) {
MainLoop loop;
Status error;
struct sigaction sa;
sa.sa_sigaction = [](int, siginfo_t *, void *) {};
sa.sa_flags = SA_SIGINFO; // important: no SA_RESTART
sigemptyset(&sa.sa_mask);
ASSERT_EQ(0, sigaction(SIGUSR2, &sa, nullptr));
auto handle = loop.RegisterSignal(SIGUSR1, make_callback(), error);
ASSERT_TRUE(error.Success());
kill(getpid(), SIGUSR2);
kill(getpid(), SIGUSR1);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
}
// Test that two callbacks can be registered for the same signal
// and unregistered independently.
TEST_F(MainLoopTest, TwoSignalCallbacks) {
MainLoop loop;
Status error;
unsigned callback2_count = 0;
unsigned callback3_count = 0;
auto handle = loop.RegisterSignal(SIGUSR1, make_callback(), error);
ASSERT_TRUE(error.Success());
{
// Run a single iteration with two callbacks enabled.
auto handle2 = loop.RegisterSignal(
SIGUSR1, [&](MainLoopBase &loop) { ++callback2_count; }, error);
ASSERT_TRUE(error.Success());
kill(getpid(), SIGUSR1);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(1u, callback_count);
ASSERT_EQ(1u, callback2_count);
ASSERT_EQ(0u, callback3_count);
}
{
// Make sure that remove + add new works.
auto handle3 = loop.RegisterSignal(
SIGUSR1, [&](MainLoopBase &loop) { ++callback3_count; }, error);
ASSERT_TRUE(error.Success());
kill(getpid(), SIGUSR1);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(2u, callback_count);
ASSERT_EQ(1u, callback2_count);
ASSERT_EQ(1u, callback3_count);
}
// Both extra callbacks should be unregistered now.
kill(getpid(), SIGUSR1);
ASSERT_TRUE(loop.Run().Success());
ASSERT_EQ(3u, callback_count);
ASSERT_EQ(1u, callback2_count);
ASSERT_EQ(1u, callback3_count);
}
#endif
|