1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
|
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix,debug.ExprInspection -verify %s
#include "Inputs/system-header-simulator.h"
#include "Inputs/system-header-simulator-for-malloc.h"
#include "Inputs/system-header-simulator-for-valist.h"
void clang_analyzer_eval(int);
void clang_analyzer_dump_int(int);
void clang_analyzer_dump_ptr(void*);
void clang_analyzer_warnIfReached();
void test_getline_null_lineptr() {
FILE *F1 = tmpfile();
if (!F1)
return;
char **buffer = NULL;
size_t n = 0;
getline(buffer, &n, F1); // expected-warning {{Line pointer might be NULL}}
fclose(F1);
}
void test_getline_null_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
getline(&buffer, NULL, F1); // expected-warning {{Size pointer might be NULL}}
fclose(F1);
}
void test_getline_null_buffer_size_gt0() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
size_t n = 8;
getline(&buffer, &n, F1); // ok since posix 2018
free(buffer);
fclose(F1);
}
void test_getline_null_buffer_size_gt0_2(size_t n) {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
if (n > 0) {
getline(&buffer, &n, F1); // ok since posix 2018
}
free(buffer);
fclose(F1);
}
void test_getline_null_buffer_unknown_size(size_t n) {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
getline(&buffer, &n, F1); // ok
fclose(F1);
free(buffer);
}
void test_getline_null_buffer_undef_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
size_t n;
getline(&buffer, &n, F1); // ok since posix 2018
fclose(F1);
free(buffer);
}
void test_getline_buffer_size_0() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = malloc(10);
size_t n = 0;
if (buffer != NULL)
getline(&buffer, &n, F1); // ok, the buffer is enough for 0 character
fclose(F1);
free(buffer);
}
void test_getline_buffer_bad_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = malloc(10);
size_t n = 100;
if (buffer != NULL)
getline(&buffer, &n, F1); // expected-warning {{The buffer from the first argument is smaller than the size specified by the second parameter}}
fclose(F1);
free(buffer);
}
void test_getline_buffer_smaller_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = malloc(100);
size_t n = 10;
if (buffer != NULL)
getline(&buffer, &n, F1); // ok, there is enough space for 10 characters
fclose(F1);
free(buffer);
}
void test_getline_buffer_undef_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = malloc(100);
size_t n;
if (buffer != NULL)
getline(&buffer, &n, F1); // expected-warning {{The buffer from the first argument is not NULL, but the size specified by the second parameter is undefined}}
fclose(F1);
free(buffer);
}
void test_getline_null_buffer() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
size_t n = 0;
ssize_t r = getline(&buffer, &n, F1);
// getline returns -1 on failure, number of char reads on success (>= 0)
if (r < -1) {
clang_analyzer_warnIfReached(); // must not happen
} else {
// The buffer could be allocated both on failure and success
clang_analyzer_dump_int(n); // expected-warning {{conj_$}}
clang_analyzer_dump_ptr(buffer); // expected-warning {{conj_$}}
}
free(buffer);
fclose(F1);
}
void test_getdelim_null_size() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
getdelim(&buffer, NULL, ',', F1); // expected-warning {{Size pointer might be NULL}}
fclose(F1);
}
void test_getdelim_null_buffer_size_gt0() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
size_t n = 8;
getdelim(&buffer, &n, ';', F1); // ok since posix 2018
free(buffer);
fclose(F1);
}
void test_getdelim_null_buffer_size_gt0_2(size_t n) {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
if (n > 0) {
getdelim(&buffer, &n, ' ', F1); // ok since posix 2018
}
free(buffer);
fclose(F1);
}
void test_getdelim_null_buffer_unknown_size(size_t n) {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
getdelim(&buffer, &n, '-', F1); // ok
fclose(F1);
free(buffer);
}
void test_getdelim_null_buffer() {
FILE *F1 = tmpfile();
if (!F1)
return;
char *buffer = NULL;
size_t n = 0;
ssize_t r = getdelim(&buffer, &n, '\r', F1);
// getdelim returns -1 on failure, number of char reads on success (>= 0)
if (r < -1) {
clang_analyzer_warnIfReached(); // must not happen
}
else {
// The buffer could be allocated both on failure and success
clang_analyzer_dump_int(n); // expected-warning {{conj_$}}
clang_analyzer_dump_ptr(buffer); // expected-warning {{conj_$}}
}
free(buffer);
fclose(F1);
}
void test_getline_while() {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
char *line = NULL;
size_t len = 0;
ssize_t read;
while ((read = getline(&line, &len, file)) != -1) {
printf("%s\n", line);
}
free(line);
fclose(file);
}
void test_getline_return_check() {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
char *line = NULL;
size_t len = 0;
ssize_t r = getline(&line, &len, file);
if (r != -1) {
if (line[0] == '\0') {} // ok
}
free(line);
fclose(file);
}
void test_getline_clear_eof() {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
size_t n = 10;
char *buffer = malloc(n);
ssize_t read = fread(buffer, n, 1, file);
if (feof(file)) {
clearerr(file);
getline(&buffer, &n, file); // ok
}
fclose(file);
free(buffer);
}
void test_getline_not_null(char **buffer, size_t *size) {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
getline(buffer, size, file);
fclose(file);
if (size == NULL || buffer == NULL) {
clang_analyzer_warnIfReached(); // must not happen
}
}
void test_getline_size_constraint(size_t size) {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
size_t old_size = size;
char *buffer = malloc(10);
if (buffer != NULL) {
ssize_t r = getline(&buffer, &size, file);
if (r >= 0) {
// Since buffer has a size of 10, old_size must be less than or equal to 10.
// Otherwise, there would be UB.
clang_analyzer_eval(old_size <= 10); // expected-warning{{TRUE}}
}
}
fclose(file);
free(buffer);
}
void test_getline_negative_buffer() {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
char *buffer = NULL;
size_t n = -1;
getline(&buffer, &n, file); // ok since posix 2018
free(buffer);
fclose(file);
}
void test_getline_negative_buffer_2(char *buffer) {
FILE *file = fopen("file.txt", "r");
if (file == NULL) {
return;
}
size_t n = -1;
(void)getline(&buffer, &n, file); // ok
free(buffer);
fclose(file);
}
|
