1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
//===--- RedundantInlineSpecifierCheck.cpp - clang-tidy--------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "RedundantInlineSpecifierCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/AST/Decl.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/ExprCXX.h"
#include "clang/ASTMatchers/ASTMatchers.h"
#include "clang/Basic/Diagnostic.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Basic/SourceManager.h"
#include "clang/Lex/Token.h"
#include "../utils/LexerUtils.h"
using namespace clang::ast_matchers;
namespace clang::tidy::readability {
namespace {
AST_POLYMORPHIC_MATCHER(isInlineSpecified,
AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl,
VarDecl)) {
if (const auto *FD = dyn_cast<FunctionDecl>(&Node))
return FD->isInlineSpecified();
if (const auto *VD = dyn_cast<VarDecl>(&Node))
return VD->isInlineSpecified();
llvm_unreachable("Not a valid polymorphic type");
}
AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl,
VarDecl),
bool, StrictMode) {
if (!StrictMode)
return false;
if (const auto *FD = dyn_cast<FunctionDecl>(&Node))
return FD->getStorageClass() == SC_Static || FD->isInAnonymousNamespace();
if (const auto *VD = dyn_cast<VarDecl>(&Node))
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
} // namespace
static SourceLocation getInlineTokenLocation(SourceRange RangeLocation,
const SourceManager &Sources,
const LangOptions &LangOpts) {
SourceLocation Loc = RangeLocation.getBegin();
if (Loc.isMacroID())
return {};
Token FirstToken;
Lexer::getRawToken(Loc, FirstToken, Sources, LangOpts, true);
std::optional<Token> CurrentToken = FirstToken;
while (CurrentToken && CurrentToken->getLocation() < RangeLocation.getEnd() &&
CurrentToken->isNot(tok::eof)) {
if (CurrentToken->is(tok::raw_identifier) &&
CurrentToken->getRawIdentifier() == "inline")
return CurrentToken->getLocation();
CurrentToken =
Lexer::findNextToken(CurrentToken->getLocation(), Sources, LangOpts);
}
return {};
}
void RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
const auto IsPartOfRecordDecl = hasAncestor(recordDecl());
Finder->addMatcher(
functionDecl(isInlineSpecified(),
anyOf(isConstexpr(), isDeleted(),
allOf(isDefaulted(), IsPartOfRecordDecl),
isInternalLinkage(StrictMode),
allOf(isDefinition(), IsPartOfRecordDecl)))
.bind("fun_decl"),
this);
if (StrictMode)
Finder->addMatcher(
functionTemplateDecl(
has(functionDecl(allOf(isInlineSpecified(), isDefinition()))))
.bind("templ_decl"),
this);
if (getLangOpts().CPlusPlus17) {
Finder->addMatcher(
varDecl(
isInlineSpecified(),
anyOf(allOf(isInternalLinkage(StrictMode),
unless(allOf(hasInitializer(expr()), IsPartOfRecordDecl,
isStaticStorageClass()))),
allOf(isConstexpr(), IsPartOfRecordDecl)))
.bind("var_decl"),
this);
}
}
template <typename T>
void RedundantInlineSpecifierCheck::handleMatchedDecl(
const T *MatchedDecl, const SourceManager &Sources,
const MatchFinder::MatchResult &Result, StringRef Message) {
SourceLocation Loc = getInlineTokenLocation(
MatchedDecl->getSourceRange(), Sources, Result.Context->getLangOpts());
if (Loc.isValid())
diag(Loc, Message) << MatchedDecl << FixItHint::CreateRemoval(Loc);
}
void RedundantInlineSpecifierCheck::check(
const MatchFinder::MatchResult &Result) {
const SourceManager &Sources = *Result.SourceManager;
if (const auto *MatchedDecl =
Result.Nodes.getNodeAs<FunctionDecl>("fun_decl")) {
handleMatchedDecl(
MatchedDecl, Sources, Result,
"function %0 has inline specifier but is implicitly inlined");
} else if (const auto *MatchedDecl =
Result.Nodes.getNodeAs<VarDecl>("var_decl")) {
handleMatchedDecl(
MatchedDecl, Sources, Result,
"variable %0 has inline specifier but is implicitly inlined");
} else if (const auto *MatchedDecl =
Result.Nodes.getNodeAs<FunctionTemplateDecl>("templ_decl")) {
handleMatchedDecl(
MatchedDecl, Sources, Result,
"function %0 has inline specifier but is implicitly inlined");
}
}
} // namespace clang::tidy::readability
|
