diff options
Diffstat (limited to 'offload/liboffload/src/OffloadImpl.cpp')
-rw-r--r-- | offload/liboffload/src/OffloadImpl.cpp | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/offload/liboffload/src/OffloadImpl.cpp b/offload/liboffload/src/OffloadImpl.cpp index 272a12a..f5365ca 100644 --- a/offload/liboffload/src/OffloadImpl.cpp +++ b/offload/liboffload/src/OffloadImpl.cpp @@ -208,7 +208,7 @@ Error initPlugins(OffloadContext &Context) { } Error olInit_impl() { - std::lock_guard<std::mutex> Lock{OffloadContextValMutex}; + std::lock_guard<std::mutex> Lock(OffloadContextValMutex); if (isOffloadInitialized()) { OffloadContext::get().RefCount++; @@ -226,7 +226,7 @@ Error olInit_impl() { } Error olShutDown_impl() { - std::lock_guard<std::mutex> Lock{OffloadContextValMutex}; + std::lock_guard<std::mutex> Lock(OffloadContextValMutex); if (--OffloadContext::get().RefCount != 0) return Error::success(); @@ -487,16 +487,13 @@ Error olSyncQueue_impl(ol_queue_handle_t Queue) { // Host plugin doesn't have a queue set so it's not safe to call synchronize // on it, but we have nothing to synchronize in that situation anyway. if (Queue->AsyncInfo->Queue) { - if (auto Err = Queue->Device->Device->synchronize(Queue->AsyncInfo)) + // We don't need to release the queue and we would like the ability for + // other offload threads to submit work concurrently, so pass "false" here + // so we don't release the underlying queue object. + if (auto Err = Queue->Device->Device->synchronize(Queue->AsyncInfo, false)) return Err; } - // Recreate the stream resource so the queue can be reused - // TODO: Would be easier for the synchronization to (optionally) not release - // it to begin with. - if (auto Res = Queue->Device->Device->initAsyncInfo(&Queue->AsyncInfo)) - return Res; - return Error::success(); } @@ -530,6 +527,12 @@ Error olGetQueueInfoImplDetail(ol_queue_handle_t Queue, switch (PropName) { case OL_QUEUE_INFO_DEVICE: return Info.write<ol_device_handle_t>(Queue->Device); + case OL_QUEUE_INFO_EMPTY: { + auto Pending = Queue->Device->Device->hasPendingWork(Queue->AsyncInfo); + if (auto Err = Pending.takeError()) + return Err; + return Info.write<bool>(!*Pending); + } default: return createOffloadError(ErrorCode::INVALID_ENUMERATION, "olGetQueueInfo enum '%i' is invalid", PropName); @@ -741,7 +744,7 @@ Error olGetSymbol_impl(ol_program_handle_t Program, const char *Name, ol_symbol_kind_t Kind, ol_symbol_handle_t *Symbol) { auto &Device = Program->Image->getDevice(); - std::lock_guard<std::mutex> Lock{Program->SymbolListMutex}; + std::lock_guard<std::mutex> Lock(Program->SymbolListMutex); switch (Kind) { case OL_SYMBOL_KIND_KERNEL: { |