diff options
Diffstat (limited to 'lldb/source/Commands/CommandObjectWatchpointCommand.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectWatchpointCommand.cpp | 29 |
1 files changed, 12 insertions, 17 deletions
diff --git a/lldb/source/Commands/CommandObjectWatchpointCommand.cpp b/lldb/source/Commands/CommandObjectWatchpointCommand.cpp index 37052dd..b1629ce 100644 --- a/lldb/source/Commands/CommandObjectWatchpointCommand.cpp +++ b/lldb/source/Commands/CommandObjectWatchpointCommand.cpp @@ -366,7 +366,7 @@ are no syntax errors may indicate that a function was declared but never called. }; protected: - bool DoExecute(Args &command, CommandReturnObject &result) override { + void DoExecute(Args &command, CommandReturnObject &result) override { Target *target = &GetSelectedTarget(); const WatchpointList &watchpoints = target->GetWatchpointList(); @@ -374,7 +374,7 @@ protected: if (num_watchpoints == 0) { result.AppendError("No watchpoints exist to have commands added"); - return false; + return; } if (!m_options.m_function_name.empty()) { @@ -388,7 +388,7 @@ protected: if (!CommandObjectMultiwordWatchpoint::VerifyWatchpointIDs(target, command, valid_wp_ids)) { result.AppendError("Invalid watchpoints specification."); - return false; + return; } result.SetStatus(eReturnStatusSuccessFinishNoResult); @@ -441,8 +441,6 @@ protected: } } } - - return result.Succeeded(); } private: @@ -475,7 +473,7 @@ public: ~CommandObjectWatchpointCommandDelete() override = default; protected: - bool DoExecute(Args &command, CommandReturnObject &result) override { + void DoExecute(Args &command, CommandReturnObject &result) override { Target *target = &GetSelectedTarget(); const WatchpointList &watchpoints = target->GetWatchpointList(); @@ -483,20 +481,20 @@ protected: if (num_watchpoints == 0) { result.AppendError("No watchpoints exist to have commands deleted"); - return false; + return; } if (command.GetArgumentCount() == 0) { result.AppendError( "No watchpoint specified from which to delete the commands"); - return false; + return; } std::vector<uint32_t> valid_wp_ids; if (!CommandObjectMultiwordWatchpoint::VerifyWatchpointIDs(target, command, valid_wp_ids)) { result.AppendError("Invalid watchpoints specification."); - return false; + return; } result.SetStatus(eReturnStatusSuccessFinishNoResult); @@ -509,10 +507,9 @@ protected: wp->ClearCallback(); } else { result.AppendErrorWithFormat("Invalid watchpoint ID: %u.\n", cur_wp_id); - return false; + return; } } - return result.Succeeded(); } }; @@ -543,7 +540,7 @@ public: ~CommandObjectWatchpointCommandList() override = default; protected: - bool DoExecute(Args &command, CommandReturnObject &result) override { + void DoExecute(Args &command, CommandReturnObject &result) override { Target *target = &GetSelectedTarget(); const WatchpointList &watchpoints = target->GetWatchpointList(); @@ -551,20 +548,20 @@ protected: if (num_watchpoints == 0) { result.AppendError("No watchpoints exist for which to list commands"); - return false; + return; } if (command.GetArgumentCount() == 0) { result.AppendError( "No watchpoint specified for which to list the commands"); - return false; + return; } std::vector<uint32_t> valid_wp_ids; if (!CommandObjectMultiwordWatchpoint::VerifyWatchpointIDs(target, command, valid_wp_ids)) { result.AppendError("Invalid watchpoints specification."); - return false; + return; } result.SetStatus(eReturnStatusSuccessFinishNoResult); @@ -598,8 +595,6 @@ protected: } } } - - return result.Succeeded(); } }; |