aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--lld/test/wasm/Inputs/.gitattributes3
-rw-r--r--lld/wasm/Driver.cpp2
-rw-r--r--lld/wasm/InputFiles.cpp18
3 files changed, 15 insertions, 8 deletions
diff --git a/lld/test/wasm/Inputs/.gitattributes b/lld/test/wasm/Inputs/.gitattributes
new file mode 100644
index 0000000..6622904
--- /dev/null
+++ b/lld/test/wasm/Inputs/.gitattributes
@@ -0,0 +1,3 @@
+# ensures that we test parsing of stub libraries that contain
+# windows line endings
+libstub.so text eol=crlf
diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index 8f7ed8b..762d4c9 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -281,7 +281,7 @@ void LinkerDriver::addFile(StringRef path) {
files.push_back(createObjectFile(mbref));
break;
case file_magic::unknown:
- if (mbref.getBuffer().starts_with("#STUB\n")) {
+ if (mbref.getBuffer().starts_with("#STUB")) {
files.push_back(make<StubFile>(mbref));
break;
}
diff --git a/lld/wasm/InputFiles.cpp b/lld/wasm/InputFiles.cpp
index 3d4fe93..a03166d 100644
--- a/lld/wasm/InputFiles.cpp
+++ b/lld/wasm/InputFiles.cpp
@@ -691,12 +691,16 @@ StringRef strip(StringRef s) {
}
void StubFile::parse() {
- bool first = false;
+ bool first = true;
+
+ SmallVector<StringRef> lines;
+ mb.getBuffer().split(lines, '\n');
+ for (StringRef line : lines) {
+ line = line.trim();
- for (StringRef line : args::getLines(mb)) {
// File must begin with #STUB
if (first) {
- assert(line == "#STUB\n");
+ assert(line == "#STUB");
first = false;
}
@@ -713,10 +717,10 @@ void StubFile::parse() {
symbolDependencies[sym] = {};
while (rest.size()) {
- StringRef first;
- std::tie(first, rest) = rest.split(',');
- first = strip(first);
- symbolDependencies[sym].push_back(first);
+ StringRef dep;
+ std::tie(dep, rest) = rest.split(',');
+ dep = strip(dep);
+ symbolDependencies[sym].push_back(dep);
}
}
}