diff options
| author | River Riddle <riddleriver@gmail.com> | 2020-03-12 14:06:41 -0700 |
|---|---|---|
| committer | River Riddle <riddleriver@gmail.com> | 2020-03-12 14:26:15 -0700 |
| commit | 0ddba0bd59c337f16b51a00cb205ecfda46f97fa (patch) | |
| tree | be1aaf1254f0c625d48ba66270d69b0db8b38a2e /mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp | |
| parent | 907403f342fe661b590f930a83f940c67b3ff855 (diff) | |
| download | llvm-0ddba0bd59c337f16b51a00cb205ecfda46f97fa.zip llvm-0ddba0bd59c337f16b51a00cb205ecfda46f97fa.tar.gz llvm-0ddba0bd59c337f16b51a00cb205ecfda46f97fa.tar.bz2 | |
[mlir][SideEffects] Replace HasNoSideEffect with the memory effect interfaces.
HasNoSideEffect can now be implemented using the MemoryEffectInterface, removing the need to check multiple things for the same information. This also removes an easy foot-gun for users as 'Operation::hasNoSideEffect' would ignore operations that dynamically, or recursively, have no side effects. This also leads to an immediate improvement in some of the existing users, such as DCE, now that they have access to more information.
Differential Revision: https://reviews.llvm.org/D76036
Diffstat (limited to 'mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp')
| -rw-r--r-- | mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp b/mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp index 293d935..9ba3f40 100644 --- a/mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp +++ b/mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp @@ -797,7 +797,9 @@ ParallelToGpuLaunchLowering::matchAndRewrite(ParallelOp parallelOp, Operation *clone = rewriter.clone(*op, cloningMap); cloningMap.map(op->getResults(), clone->getResults()); // Check for side effects. - seenSideeffects |= !clone->hasNoSideEffect(); + // TODO: Handle region side effects properly. + seenSideeffects |= !MemoryEffectOpInterface::hasNoEffect(clone) || + clone->getNumRegions() != 0; // If we are no longer in the innermost scope, sideeffects are disallowed. if (seenSideeffects && leftNestingScope) return matchFailure(); |