diff options
author | Nicolas van Kempen <nvankemp@gmail.com> | 2024-08-30 14:26:49 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-30 19:26:49 +0100 |
commit | c49770c60f26e449379447109f7d915bd8de0384 (patch) | |
tree | 6ccadd331d1da78ee85c0f11f12a47b6a3187035 /llvm/utils/UpdateTestChecks/common.py | |
parent | 07178981246c56e8beafe7fe49f0f442436f08c4 (diff) | |
download | llvm-c49770c60f26e449379447109f7d915bd8de0384.zip llvm-c49770c60f26e449379447109f7d915bd8de0384.tar.gz llvm-c49770c60f26e449379447109f7d915bd8de0384.tar.bz2 |
[NFC] Prefer subprocess.DEVNULL over os.devnull (#106500)
There is no need to support Python 2.7 anymore, Python 3.3+ has
`subprocess.DEVNULL`. This is good practice and also prevents file
handles from
staying open unnecessarily.
Also remove a couple unused or unneeded `__future__` imports.
Diffstat (limited to 'llvm/utils/UpdateTestChecks/common.py')
-rw-r--r-- | llvm/utils/UpdateTestChecks/common.py | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/llvm/utils/UpdateTestChecks/common.py b/llvm/utils/UpdateTestChecks/common.py index c5e4ad4..9b9be69 100644 --- a/llvm/utils/UpdateTestChecks/common.py +++ b/llvm/utils/UpdateTestChecks/common.py @@ -1,11 +1,8 @@ -from __future__ import print_function - import argparse import bisect import collections import copy import glob -import itertools import os import re import subprocess @@ -517,12 +514,13 @@ def invoke_tool(exe, cmd_args, ir, preprocess_cmd=None, verbose=False): sep="", file=sys.stderr, ) - # Python 2.7 doesn't have subprocess.DEVNULL: - with open(os.devnull, "w") as devnull: - pp = subprocess.Popen( - preprocess_cmd, shell=True, stdin=devnull, stdout=subprocess.PIPE - ) - ir_file = pp.stdout + pp = subprocess.Popen( + preprocess_cmd, + shell=True, + stdin=subprocess.DEVNULL, + stdout=subprocess.PIPE, + ) + ir_file = pp.stdout if isinstance(cmd_args, list): args = [applySubstitutions(a, substitutions) for a in cmd_args] |