diff options
author | Joel E. Denny <jdenny.ornl@gmail.com> | 2020-06-29 18:35:22 -0400 |
---|---|---|
committer | Joel E. Denny <jdenny.ornl@gmail.com> | 2020-06-29 18:35:22 -0400 |
commit | 782585a2144e2af019bd3e4dc48cab611545645b (patch) | |
tree | f5da4d5052de67624dd1ce990269a570d055603d /llvm/utils/FileCheck/FileCheck.cpp | |
parent | 632438726429859b80a68721bf91daec2d8b7b2a (diff) | |
download | llvm-782585a2144e2af019bd3e4dc48cab611545645b.zip llvm-782585a2144e2af019bd3e4dc48cab611545645b.tar.gz llvm-782585a2144e2af019bd3e4dc48cab611545645b.tar.bz2 |
[FileCheck] Permit multiple -v or -vv
`FILECHECK_OPTS` was implemented so that a test runner, such as CI,
can specify FileCheck debugging options, such as `-v` and `-vv`.
However, if a test suite has a FileCheck call that already specifies
`-v` or `-vv`, then that call will fail if `FILECHECK_OPTS` also
specifies it.
For `-vv`, this problem already exists:
`clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c`
It's not yet clear if the `-vv` in that test was intentional, but this
usage shouldn't fail anyway. It's already true that FileCheck permits
`-vv` and `-v` together even though `-vv` implies `-v`.
Compare D70784, which fixed the same problem for `-dump-input`.
Reviewed By: jhenderson, thopre
Differential Revision: https://reviews.llvm.org/D82601
Diffstat (limited to 'llvm/utils/FileCheck/FileCheck.cpp')
-rw-r--r-- | llvm/utils/FileCheck/FileCheck.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/utils/FileCheck/FileCheck.cpp b/llvm/utils/FileCheck/FileCheck.cpp index 52d0fb8..e0037b5 100644 --- a/llvm/utils/FileCheck/FileCheck.cpp +++ b/llvm/utils/FileCheck/FileCheck.cpp @@ -97,12 +97,12 @@ static cl::opt<bool> AllowDeprecatedDagOverlap( "non-overlapping CHECK-DAG implementation.\n")); static cl::opt<bool> Verbose( - "v", cl::init(false), + "v", cl::init(false), cl::ZeroOrMore, cl::desc("Print directive pattern matches, or add them to the input dump\n" "if enabled.\n")); static cl::opt<bool> VerboseVerbose( - "vv", cl::init(false), + "vv", cl::init(false), cl::ZeroOrMore, cl::desc("Print information helpful in diagnosing internal FileCheck\n" "issues, or add it to the input dump if enabled. Implies\n" "-v.\n")); |