Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.

1 files changed, 1 insertions, 1 deletions

diff --git a/llvm/unittests/Support/FileUtilitiesTest.cpp b/llvm/unittests/Support/FileUtilitiesTest.cpp
index 2bf9dc5..7fbb601 100644
--- a/llvm/unittests/Support/FileUtilitiesTest.cpp
+++ b/llvm/unittests/Support/FileUtilitiesTest.cpp
@@ -44,7 +44,7 @@ TEST(writeFileAtomicallyTest, Test) {
   llvm::Error Err = llvm::writeFileAtomically(TempUniqTestFileModel, FinalTestfilePath, TestfileContent);
   ASSERT_FALSE(static_cast<bool>(Err));
 
-  std::ifstream FinalFileStream(FinalTestfilePath.str());
+  std::ifstream FinalFileStream(std::string(FinalTestfilePath.str()));
   std::string FinalFileContent;
   FinalFileStream >> FinalFileContent;
   ASSERT_EQ(FinalFileContent, TestfileContent);