diff options
author | Fangrui Song <maskray@google.com> | 2020-07-31 10:46:27 -0700 |
---|---|---|
committer | Fangrui Song <maskray@google.com> | 2020-07-31 10:48:09 -0700 |
commit | c068e9c8c123e7f8c8f3feb57245a012ccd09ccf (patch) | |
tree | 1eec1e330ee35c219ecf0b0d154c4f4dc3b8d134 /llvm/unittests/Support/CommandLineTest.cpp | |
parent | 93fd8dbdc250330b84eeca3387e895407663d750 (diff) | |
download | llvm-c068e9c8c123e7f8c8f3feb57245a012ccd09ccf.zip llvm-c068e9c8c123e7f8c8f3feb57245a012ccd09ccf.tar.gz llvm-c068e9c8c123e7f8c8f3feb57245a012ccd09ccf.tar.bz2 |
[Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions
The function was added in 2003. It is not used and can be emulated with ParseCommandLineOptions.
Diffstat (limited to 'llvm/unittests/Support/CommandLineTest.cpp')
-rw-r--r-- | llvm/unittests/Support/CommandLineTest.cpp | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/llvm/unittests/Support/CommandLineTest.cpp b/llvm/unittests/Support/CommandLineTest.cpp index e8c2cef..be8217b 100644 --- a/llvm/unittests/Support/CommandLineTest.cpp +++ b/llvm/unittests/Support/CommandLineTest.cpp @@ -45,8 +45,6 @@ class TempEnvVar { EXPECT_EQ(nullptr, old_value) << old_value; #if HAVE_SETENV setenv(name, value, true); -#else -# define SKIP_ENVIRONMENT_TESTS #endif } @@ -137,36 +135,6 @@ TEST(CommandLineTest, ModifyExisitingOption) { ASSERT_EQ(cl::Hidden, TestOption.getOptionHiddenFlag()) << "Failed to modify option's hidden flag."; } -#ifndef SKIP_ENVIRONMENT_TESTS - -const char test_env_var[] = "LLVM_TEST_COMMAND_LINE_FLAGS"; - -cl::opt<std::string> EnvironmentTestOption("env-test-opt"); -TEST(CommandLineTest, ParseEnvironment) { - TempEnvVar TEV(test_env_var, "-env-test-opt=hello"); - EXPECT_EQ("", EnvironmentTestOption); - cl::ParseEnvironmentOptions("CommandLineTest", test_env_var); - EXPECT_EQ("hello", EnvironmentTestOption); -} - -// This test used to make valgrind complain -// ("Conditional jump or move depends on uninitialised value(s)") -// -// Warning: Do not run any tests after this one that try to gain access to -// registered command line options because this will likely result in a -// SEGFAULT. This can occur because the cl::opt in the test below is declared -// on the stack which will be destroyed after the test completes but the -// command line system will still hold a pointer to a deallocated cl::Option. -TEST(CommandLineTest, ParseEnvironmentToLocalVar) { - // Put cl::opt on stack to check for proper initialization of fields. - StackOption<std::string> EnvironmentTestOptionLocal("env-test-opt-local"); - TempEnvVar TEV(test_env_var, "-env-test-opt-local=hello-local"); - EXPECT_EQ("", EnvironmentTestOptionLocal); - cl::ParseEnvironmentOptions("CommandLineTest", test_env_var); - EXPECT_EQ("hello-local", EnvironmentTestOptionLocal); -} - -#endif // SKIP_ENVIRONMENT_TESTS TEST(CommandLineTest, UseOptionCategory) { StackOption<int> TestOption2("test-option", cl::cat(TestCategory)); |