aboutsummaryrefslogtreecommitdiff
path: root/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
diff options
context:
space:
mode:
authorFangrui Song <i@maskray.me>2025-07-26 00:05:10 -0700
committerFangrui Song <i@maskray.me>2025-07-26 00:05:10 -0700
commitb22e22ebfa546cc31e166dd5ca4cc808aa057c9b (patch)
tree68e6826bb41b6ae37a1e415b72c31dc6e3647299 /llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
parent9475ed84909463ad594602dd76583f4ff12efcd0 (diff)
downloadllvm-b22e22ebfa546cc31e166dd5ca4cc808aa057c9b.zip
llvm-b22e22ebfa546cc31e166dd5ca4cc808aa057c9b.tar.gz
llvm-b22e22ebfa546cc31e166dd5ca4cc808aa057c9b.tar.bz2
MC: Allocate initial fragment and define section symbol in changeSection
Reland #150574 with a MCStreamer::changeSection change: In Mach-O, DWARF sections use Begin as a temporary label, requiring a label definition, unlike section symbols in other file formats. (Tested by dec978036ef1037753e7de5b78c978e71c49217b) --- 13a79bbfe583e1d8cc85d241b580907260065eb8 (2017) introduced fragment creation in MCContext for createELFSectionImpl, which was inappropriate. Fragments should only be created when using MCSteramer, not during `MCContext::get*Section` calls. `initMachOMCObjectFileInfo` defines multiple sections, some of which may not be used by the code generator. This caused symbol names matching these sections to be incorrectly marked as undefined (see https://reviews.llvm.org/D55173). The fragment code was later replicated in other file formats, such as WebAssembly (see https://reviews.llvm.org/D46561), XCOFF, and GOFF. This patch fixes the problem by moving initial fragment allocation from MCContext::createSection to MCStreamer::changeSection. While MCContext still creates a section symbol, the symbol is not attached to the initial fragment. In addition, * Move `emitLabel`/`setFragment` from `switchSection*` and overridden changeSection to `MCObjectStreamer::changeSection` for consistency. * De-virtualize `switchSectionNoPrint`. * test/CodeGen/XCore/section-name.ll now passes. XCore doesn't support MCObjectStreamer. I don't think the MCAsmStreamer output behavior change matters. Pull Request: https://github.com/llvm/llvm-project/pull/150574
Diffstat (limited to 'llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp')
0 files changed, 0 insertions, 0 deletions